Skip to content

Commit 053a0f3

Browse files
authored
[native_assets_cli] Separate out public API (#885)
This does not change any of the public API yet, but it slims down the API surface of `package:native_assets_cli` to the bare minimum. Internal details may be accessed in `package:native_assets_builder` via: ```dart import 'package:native_assets_cli/native_assets_cli_internal.dart'; ``` This enables the yaml serialization/deserialization to live in one place and be unit tested as one. One hack is that we also access `package:native_assets_cli/native_assets_cli_internal.dart` in `package:native_toolchain_c` in the unit tests to depend on the C compilers provided on the Dart CI.
1 parent a1d2bb6 commit 053a0f3

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+1078
-127
lines changed

pkgs/native_assets_builder/lib/src/build_runner/build_runner.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import 'dart:async';
66
import 'dart:io';
77

88
import 'package:logging/logging.dart';
9-
import 'package:native_assets_cli/native_assets_cli.dart';
9+
import 'package:native_assets_cli/native_assets_cli_internal.dart';
1010
import 'package:package_config/package_config.dart';
1111

1212
import '../package_layout/package_layout.dart';

pkgs/native_assets_builder/lib/src/model/asset.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
import 'package:native_assets_cli/native_assets_cli.dart';
5+
import 'package:native_assets_cli/native_assets_cli_internal.dart';
66

77
import '../utils/yaml.dart';
88

pkgs/native_assets_builder/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ environment:
1010
dependencies:
1111
graphs: ^2.3.1
1212
logging: ^1.2.0
13-
native_assets_cli: ^0.3.2
13+
native_assets_cli: ^0.4.0
1414
package_config: ^2.1.0
1515
yaml: ^3.1.2
1616
yaml_edit: ^2.1.0

pkgs/native_assets_builder/test/build_runner/build_runner_dry_run_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import 'dart:io';
66

77
import 'package:file_testing/file_testing.dart';
8-
import 'package:native_assets_cli/native_assets_cli.dart';
8+
import 'package:native_assets_cli/native_assets_cli_internal.dart';
99
import 'package:test/test.dart';
1010

1111
import '../helpers.dart';

pkgs/native_assets_builder/test/build_runner/build_runner_reusability_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
import 'package:native_assets_builder/src/build_runner/build_runner.dart';
6-
import 'package:native_assets_cli/native_assets_cli.dart';
6+
import 'package:native_assets_cli/native_assets_cli_internal.dart';
77
import 'package:test/test.dart';
88

99
import '../helpers.dart';

pkgs/native_assets_builder/test/build_runner/build_runner_run_in_isolation_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import 'dart:io';
66

7-
import 'package:native_assets_cli/native_assets_cli.dart';
7+
import 'package:native_assets_cli/native_assets_cli_internal.dart';
88
import 'package:test/test.dart';
99

1010
import '../helpers.dart';

pkgs/native_assets_builder/test/build_runner/helpers.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import 'dart:io';
88
import 'package:file_testing/file_testing.dart';
99
import 'package:logging/logging.dart';
1010
import 'package:native_assets_builder/native_assets_builder.dart';
11-
import 'package:native_assets_cli/native_assets_cli.dart';
11+
import 'package:native_assets_cli/native_assets_cli_internal.dart';
1212
import 'package:test/test.dart';
1313

1414
import '../helpers.dart';

pkgs/native_assets_builder/test/build_runner/packaging_preference_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
import 'package:native_assets_cli/native_assets_cli.dart';
5+
import 'package:native_assets_cli/native_assets_cli_internal.dart';
66
import 'package:test/test.dart';
77

88
import '../helpers.dart';

pkgs/native_assets_builder/test/data/cyclic_package_1/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ dependencies:
1111
cli_config: ^0.1.1
1212
cyclic_package_2:
1313
path: ../cyclic_package_2
14-
native_assets_cli: ^0.3.2
14+
native_assets_cli: ^0.4.0
1515
yaml: ^3.1.1
1616
yaml_edit: ^2.1.0
1717

pkgs/native_assets_builder/test/data/cyclic_package_2/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ dependencies:
1111
cli_config: ^0.1.1
1212
cyclic_package_1:
1313
path: ../cyclic_package_1
14-
native_assets_cli: ^0.3.2
14+
native_assets_cli: ^0.4.0
1515
yaml: ^3.1.1
1616
yaml_edit: ^2.1.0
1717

0 commit comments

Comments
 (0)