Skip to content

Add a generator script to regenerate native bindings #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brianquinlan
Copy link
Contributor

@brianquinlan brianquinlan commented Jul 17, 2025

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:io_file labels Jul 17, 2025
@brianquinlan brianquinlan changed the title Add a generator script to regenerate native bindings. Add a generator script to regenerate native bindings Jul 17, 2025
@brianquinlan brianquinlan requested a review from dcharkes July 17, 2025 22:02

void _formatFile(String path) {
final formatter = DartFormatter(
languageVersion: DartFormatter.latestLanguageVersion,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You might want to do Process.run(Platform.executable, ['format']) now that the formatter has subtle changes per language version.

}

void main() async {
build_constants.main();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose all generators throw on failure? Or do you need to check a return value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:io_file type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants