-
Notifications
You must be signed in to change notification settings - Fork 382
Open
Labels
next-breaking-releaseIssues that are worth doing but need to wait for a breaking version bumpIssues that are worth doing but need to wait for a breaking version bumppackage:web_socket_channel
Description
We currently have over a thousand lines of code to support a single API:
That API has very little usage. I think the only Dart team usage may be from shelf_web_socket
.
As far as I can tell, unless we either give access to the underlying Socket
from the package:shelf
APIs it is not possible to implement the shelf_web_socket
behavior without this copied code from the SDK living somewhere.
We could consider adding a WebSocket.upgrade(Stream<List<int>>, StreamSink<List<int>>)
static method in dart:io
which I think would give us enough to remove the copied code.
Metadata
Metadata
Assignees
Labels
next-breaking-releaseIssues that are worth doing but need to wait for a breaking version bumpIssues that are worth doing but need to wait for a breaking version bumppackage:web_socket_channel