Only hide @internal

Author: sigurdm

lib/src/model/model_element.dart

@@ -432,9 +432,6 @@ abstract class ModelElement
     if (element.isInternal) {
       return false;
     }
-    if (element.isVisibleForTesting) {
-      return false;
-    }
     return !element.hasPrivateName && !hasNodoc;
   }();
 

test/end2end/model_test.dart

@@ -3830,35 +3830,6 @@ String? topLevelFunction(int param1, bool param2, Cool coolBeans,
           isTrue);
     });
 
-    test('@visibleForTesting annotation hides element from docs', () {
-      expect(exLibrary.functions.named('testingMethod').isPublic, false);
-
-      expect(
-          exLibrary.classes
-              .named('Apple')
-              .allFields
-              .named('testField')
-              .isPublic,
-          isFalse);
-
-      expect(
-          exLibrary.classes
-              .named('Apple')
-              .instanceMethods
-              .named('testMethod')
-              .isPublic,
-          isFalse);
-
-      // The overridden method is not internal, and thus exposed.
-      expect(
-          exLibrary.classes
-              .named('B')
-              .instanceMethods
-              .named('testMethod')
-              .isPublic,
-          isTrue);
-    });
-
     test('type arguments are correct', () {
       var modelType = mapWithDynamicKeys.modelType as ParameterizedElementType;
       expect(modelType.typeArguments, hasLength(2));

testing/test_package/lib/example.dart

@@ -13,7 +13,7 @@ import 'package:test_package_imported/main.dart';
 
 export 'package:args/args.dart' show ArgParser;
 export 'dart:core' show deprecated, Deprecated;
-import 'package:meta/meta.dart' show protected, factory, internal, visibleForTesting;
+import 'package:meta/meta.dart' show protected, factory, internal;
 
 export 'fake.dart' show Cool, ClassTemplateOneLiner;
 export 'src/mylib.dart' show Helper;
@@ -34,10 +34,6 @@ const DO_NOT_DOCUMENT = 'not documented';
 @internal
 final topLevelInternal = 'not documented';
 
-/// top level testing function
-@visibleForTesting
-String testingMethod() => 'not documented';
-
 /// This is the same name as a top-level const from the fake lib.
 const incorrectDocReference = 'same name as const from fake';
 
@@ -134,10 +130,6 @@ class Apple {
   /// No public docs for this
   @internal
   int? internalField;
-  
-  /// No public docs for this   
-  @visibleForTesting
-  int? testField;
 
   ///Constructor
   Apple();
@@ -184,10 +176,6 @@ class Apple {
   /// No public docs for this   
   @internal
   void internalMethod() {}
-  
-  /// No public docs for this   
-  @visibleForTesting
-  void testMethod() {}
 
   void paramFromExportLib(Helper helper) {}