Fix all strong mode warnings.

[email protected]

Review URL: https://codereview.chromium.org//1830053002 .

Author: nex3

.analysis_options

@@ -0,0 +1,2 @@
+analyzer:
+  strong-mode: true

CHANGELOG.md

@@ -1,6 +1,10 @@
+## 1.6.2
+
+* Fix all strong mode warnings.
+
 ## 1.6.1
 
-* Use `StacktTrace.current` in Dart SDK 1.14 to get the current stack trace.
+* Use `StackTrace.current` in Dart SDK 1.14 to get the current stack trace.
 
 ## 1.6.0
 

lib/src/chain.dart

@@ -193,7 +193,7 @@ class Chain implements StackTrace {
   ///
   /// The trace version of a chain is just the concatenation of all the traces
   /// in the chain.
-  Trace toTrace() => new Trace(flatten(traces.map((trace) => trace.frames)));
+  Trace toTrace() => new Trace(traces.expand((trace) => trace.frames));
 
   String toString() {
     // Figure out the longest path so we know how much to pad.

lib/src/trace.dart

@@ -257,7 +257,7 @@ class Trace implements StackTrace {
       };
     }
 
-    var newFrames = [];
+    var newFrames = <Frame>[];
     for (var frame in frames.reversed) {
       if (frame is UnparsedFrame || !predicate(frame)) {
         newFrames.add(frame);

lib/src/utils.dart

@@ -19,20 +19,3 @@ String padRight(String string, int length) {
 
   return result.toString();
 }
-
-/// Flattens nested lists inside an iterable into a single list containing only
-/// non-list elements.
-List flatten(Iterable nested) {
-  var result = [];
-  helper(list) {
-    for (var element in list) {
-      if (element is List) {
-        helper(element);
-      } else {
-        result.add(element);
-      }
-    }
-  }
-  helper(nested);
-  return result;
-}

pubspec.yaml

@@ -7,7 +7,7 @@ name: stack_trace
 #
 # When the major version is upgraded, you *must* update that version constraint
 # in pub to stay in sync with this.
-version: 1.6.2-dev
+version: 1.6.2
 author: "Dart Team <[email protected]>"
 homepage: http://github.com/dart-lang/stack_trace
 description: >