update test (#4084)

* update test

* fixed codes

* update patttern-for test

Author: pq

test/rules/non_constant_identifier_names_test.dart

@@ -22,25 +22,25 @@ class NonConstantIdentifierNamesPatternsTest extends LintRuleTest {
   @override
   String get lintRule => 'non_constant_identifier_names';
 
-  @FailingTest(reason: 'Flow analysis fails w/ a Bad state exception')
   test_patternForStatement() async {
     await assertDiagnostics(r'''
 void f() {
-  for (var (AB, ) = (0, 1); AB <= 13; (AB, ) = ( , AB++)) { }
+  for (var (AB, c) = (0, 1); AB <= 13; (AB, c) = (c, AB + c)) { }
 }
 ''', [
-      lint(18, 2),
+      lint(23, 2),
     ]);
   }
 
   test_patternIfStatement() async {
     await assertDiagnostics(r'''
 void f() {
-  if ([1,2] case [int AB, int]) { }
+  if ([1,2] case [int AB, int c]) { }
 }
 ''', [
       error(WarningCode.UNUSED_LOCAL_VARIABLE, 33, 2),
       lint(33, 2),
+      error(WarningCode.UNUSED_LOCAL_VARIABLE, 41, 1),
     ]);
   }