Strong-mode errors in common pub packages

[ochafik]

This is an umbrella issue to keep track of packages that need an update before we can compile "real-world" angular2 applications:

• package:angular2 (Remove strong mode errors and warnings in Angular2 angular/angular#7356)
• package:collection (https://github.com/dart-lang/collection/issues/23)
• package:protobuf (Strong-mode analysis errors prevent DDC compilation google/protobuf.dart#54)
• package:quiver (Strong-mode analysis errors prevent DDC compilation google/quiver-dart#285)

[vsmenon]

@skybrian

[ochafik]

Note: even when projects are made clean, would be nice to ensure they remain that way. Quiver already runs the analyzer in travis (just needs --strong after it's fixed), but we may want to suggest a config like the following (untested) for the other projects:

language: dart
dart:
  - stable
  - dev
script:
  - dartanalyzer --strong `find lib -name '*.dart'`
  - pub run test:test
matrix:
  allow_failures:
    - dart: dev

@leafpetersen WDYT? (this allows for some temporary dev breakages)

[leafpetersen]

Looks reasonable, but I don't know enough about travis to be sure about some of the details. Are there any potential issues with generated files not being present, or will they be built at that point if required? Will all of the packages have been downloaded at that point so that resolution will succeed?

@bwilkerson will the analyzer do the right thing if you point it directly at a part file (i.e. only analyze it in the context that it is included in and not try to analyze it standalone)? Also, I think you talked about adding support for pointing the CLI analyzer at a directory instead of specific files - is this in the works or back burner?

[skybrian]

For protobuf we're using buildbot [1]. Is there a good way to run the analyzer there?

[1] https://github.com/dart-lang/dart-protobuf/blob/master/.test_config

[ochafik]

Not sure TBH, but analyzer_cli seems to have both buildbot & travis configured.

[ochafik]

@leafpetersen Re/ package resolution, I believe Travis' Dart config runs pub get in one of its setup phases (prolly install or before_script, see lifecycle doc). Any other codegen would have to be listed explicitly in the .travis.yml config.

[a14n]

Exactly, pub get is done at install phase ( see https://github.com/travis-ci/travis-build/blob/master/lib/travis/build/script/dart.rb#L82-L86 )

[jmesserly]

I'm guessing this was fixed a while ago :)