Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentError happens when 'on_shutdown' is called #7

Open
tunepolo opened this issue Apr 27, 2015 · 1 comment
Open

ArgumentError happens when 'on_shutdown' is called #7

tunepolo opened this issue Apr 27, 2015 · 1 comment

Comments

@tunepolo
Copy link

By af0c7ee commit, parent 'on_shutdown'(=base-event-manager.rb) invocation is added.

[lib/padrino-websockets/faye/event-manager.rb]

def on_shutdown(event)
  @pinger.cancel if @pinger
  super
end

[lib/padrino-websockets/base-event-manager.rb]

def on_shutdown
  logger.debug "Disconnecting user: #{@user} from channel: #{@channel}."
  @@connections[@channel].delete(@user)
end

Ruby's 'super' passes the same parameters when parameters are omitted, so ArgumentError happens.

@janus112
Copy link

@dariocravero Yes, I dont know why I did catch that one when testing, I must have tested the wrong version, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants