Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require 'oj' is not necessary in base-event-manager.rb #3

Open
tune opened this issue Aug 19, 2014 · 3 comments
Open

require 'oj' is not necessary in base-event-manager.rb #3

tune opened this issue Aug 19, 2014 · 3 comments
Labels

Comments

@tune
Copy link

tune commented Aug 19, 2014

It seems 'oj' is not mandatory for this gem.

@dariocravero
Copy link
Owner

Hey @tune, thanks for your message. However, it's being used in on_message and then inside each of the application server implementations to write to the WS. :)

@tune
Copy link
Author

tune commented Aug 21, 2014

If so, I think it's better to add dependency information to 'padrino-websockets.gemspec'.

@dariocravero
Copy link
Owner

👍 sorry I totally missed that! :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants