Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inproper defindexes in parseString #176

Open
arik123 opened this issue Jun 9, 2022 · 1 comment
Open

Inproper defindexes in parseString #176

arik123 opened this issue Jun 9, 2022 · 1 comment

Comments

@arik123
Copy link

arik123 commented Jun 9, 2022

Non-Craftable Killstreak Eyelander Kit defindex returned: 5726 expected: 6527
Genuine Marxman defindex returned: 816 expected: 837
Any warpaint - you return 9536 - which is generic warpaint, instead of returning the specific warpaint defindex
Cool Candy Coated War Paint (Battle Scarred) defindex returned: 9536 expected: 17258

This is just a diference between your library and autobot library, I'm not 100% sure problem is in your library
Hot Blitzkrieg SMG (Battle Scarred) defindex returned: 203 expected: 15153

@danocmx
Copy link
Owner

danocmx commented Jun 18, 2022

Hey, these issues are related to schema implementation. That's why you can implement it on your own to fix these issues, tf2-item-format/static part is not meant for production applications, but rather for quick conversion between different formats in small applications. I've know autobot has large sets of hard coded definition indices and I'm conflicted whether or not I should try to add those to the static part. You are of course free to make a pull request.

This issue is related to the parseString function which can only obtain limited data from just item name. For parseEconItem there is an extra option useTrueDefindex to get the data from tf2 wiki link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants