Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The appstream validator has some complaints about the metainfo XML #71

Open
musicinmybrain opened this issue Sep 2, 2024 · 2 comments

Comments

@musicinmybrain
Copy link
Contributor

What Happened?

With harvey 2.0.0, and with appstreamcli from https://github.com/ximion/appstream/releases/tag/v1.0.2 as packaged in Fedora (latest upstream release is 1.0.3), appstreamcli validate --no-net io.github.danirabbit.harvey.metainfo.xml fails due to three warnings.

Steps to Reproduce

appstreamcli validate --no-net --explain io.github.danirabbit.harvey.metainfo.xml

Expected Behavior

Since appstream validate fails (exits with nonzero status) when there are warnings, even without --strict, it would be nice if the metainfo file could validate without warnings.

This is not a serious issue for me in Fedora, because it’s appstream-util validate-relax --nonet that must pass in Fedora (which it does), and I can just ignore appstreamcli validate. However, I suppose there might exist distributions or app stores / software centers that do need appstreamcli validate to succeed.

OS Version

Other Linux

Software Version

Latest release (I have run all updates)

Log output (Optional)

+ appstreamcli validate --no-net --explain /builddir/build/BUILD/harvey-2.0.0-build/BUILDROOT//usr/share/metainfo/io.github.danirabbit.harvey.metainfo.xml
W: io.github.danirabbit.harvey:48: screenshot-no-unscaled-image
   A screenshot must have at least one image that has a scaling factor of 1.

W: io.github.danirabbit.harvey:51: screenshot-invalid-env-style pantheon:dark
   The `environment` property is set to an unrecognized graphical environment/style combination.

W: io.github.danirabbit.harvey:51: screenshot-no-unscaled-image
   A screenshot must have at least one image that has a scaling factor of 1.

✘ Validation failed: warnings: 3, pedantic: 2

Hardware Info (Optional)

No response

@danirabbit
Copy link
Owner

danirabbit commented Sep 5, 2024

Opened ximion/appstream#661 to add pantheon:dark as an environment ID upstream

This app is however distributed as a Flatpak in AppCenter. Please don’t package it in Fedora. I’d much rather folks get the app directly from the remote where I maintain it

@musicinmybrain
Copy link
Contributor Author

Harvey has been packaged in Fedora for about six years, since Fedora 28, and I have maintained the package for about half that time. I chose to respect your request and orphan (stop maintaining) it. Unless another packager chooses to pick it up despite your preference, it will be automatically retired, and Fedora 41 will be the last release with a harvey RPM package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants