Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atari100k config should use task "atari100k_pong" instead of "atari_pong" #173

Open
rsun0 opened this issue Jan 21, 2025 · 0 comments
Open

Comments

@rsun0
Copy link

rsun0 commented Jan 21, 2025

In dreamerv3/configs.yaml, the atari100k example config uses the task "atari_pong"

atari100k:
task: atari_pong
run: {steps: 1.1e5, envs: 1, train_ratio: 256}

However, the first part of the task name is the "suite" which is used to select the env:

dreamerv3/dreamerv3/main.py

Lines 212 to 213 in 55c8c67

def make_env(config, index, **overrides):
suite, task = config.task.split('_', 1)

kwargs = config.env.get(suite, {})

The correct suite should be "atari100k" so the task name should be "atari100k_pong". Otherwise, the atari (Atari 200M) env config will be used instead:

env:
atari: {size: [96, 96], repeat: 4, sticky: True, gray: True, actions: all, lives: unused, noops: 30, autostart: False, pooling: 2, aggregate: max, resize: pillow, clip_reward: False}
procgen: {size: [96, 96], resize: pillow}
crafter: {size: [64, 64], logs: False}
atari100k: {size: [64, 64], repeat: 4, sticky: False, gray: False, actions: needed, lives: unused, noops: 30, autostart: False, resize: pillow, clip_reward: False}

This was referenced Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant