From 95968561835e6b6cee59082e2d1b66500b36b051 Mon Sep 17 00:00:00 2001
From: the-last-pastafarian <antunes.nicolas@gmail.com>
Date: Wed, 15 Jan 2025 17:46:42 +0100
Subject: [PATCH] =?UTF-8?q?fix=20the=20can=C2=B4t=20bind=20ngFor=20and=20n?=
 =?UTF-8?q?gIf?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 desktop/src/app/components/docedit/docedit.module.ts      | 4 +---
 .../components/widgets/changes-history-modal.component.ts | 8 ++++----
 .../src/app/components/widgets/changes-history-modal.html | 3 +--
 .../src/app/components/widgets/changes-history-modal.scss | 2 +-
 4 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/desktop/src/app/components/docedit/docedit.module.ts b/desktop/src/app/components/docedit/docedit.module.ts
index 5c52405566..11d50ce6e4 100644
--- a/desktop/src/app/components/docedit/docedit.module.ts
+++ b/desktop/src/app/components/docedit/docedit.module.ts
@@ -47,7 +47,6 @@ import { MultiLanguageTextFieldComponent } from './core/forms/widgets/multi-lang
 import { SimpleInputComponent } from './core/forms/simple-input.component';
 import { SimpleMultiInputComponent } from './core/forms/simple-multi-input.component';
 import { IdentifierComponent } from './core/forms/identifier.component';
-import { ChangesHistoryModalComponent } from '../widgets/changes-history-modal.component';
 import { CompositeComponent } from './core/forms/array-field/composite/composite.component';
 import { CompositeEntryModalComponent } from './core/forms/array-field/composite/composite-entry-modal.component';
 import { ValuelistMultiInputComponent } from './core/forms/valuelist-multi-input.component';
@@ -114,8 +113,7 @@ import { LiteratureEntryModalComponent } from './core/forms/array-field/literatu
         InvalidFieldDataComponent,
         MultiLanguageTextFieldComponent,
         CompositeComponent,
-        CompositeEntryModalComponent,
-        ChangesHistoryModalComponent
+        CompositeEntryModalComponent
     ],
     exports: [
         DoceditComponent,
diff --git a/desktop/src/app/components/widgets/changes-history-modal.component.ts b/desktop/src/app/components/widgets/changes-history-modal.component.ts
index 63fd5f6317..c143a0c097 100644
--- a/desktop/src/app/components/widgets/changes-history-modal.component.ts
+++ b/desktop/src/app/components/widgets/changes-history-modal.component.ts
@@ -1,10 +1,11 @@
 import { Component} from '@angular/core';
 import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
 import { Document } from 'idai-field-core';
-
+import { CommonModule } from '@angular/common';
 
 @Component({
     selector: 'changes-history-modal',
+    imports: [CommonModule],
     templateUrl: './changes-history-modal.html',
     styleUrls: ['./changes-history-modal.scss']
 })
@@ -31,9 +32,8 @@ export class ChangesHistoryModalComponent {
     }
 
     public async initialize() {
-        // this.category = this.projectConfiguration.getCategory(this.document.resource.category);
-        // this.printedFields = await this.getPrintedFields();
-        1
+        // TODO remove this function  ( called in private function initModal() ) 
+         1
     }
 
     public formatDateTime( date: string | Date, locale: string = 'de-DE' ) { 
diff --git a/desktop/src/app/components/widgets/changes-history-modal.html b/desktop/src/app/components/widgets/changes-history-modal.html
index 6338d05857..f38d071ca7 100644
--- a/desktop/src/app/components/widgets/changes-history-modal.html
+++ b/desktop/src/app/components/widgets/changes-history-modal.html
@@ -5,8 +5,7 @@ <h5  class="modal-title" i18n="@@widgets.historyModal.header">Änderunghistorie<
 <div class="modal-body">
     <h6>The resource <b>{{document.resource.identifier}}</b> has been created by the user {{document.created.user}} the {{formatDateTime(document.created.date)}}</h6>
     <div id="changes-history-modal-body" class="modal-body">
-        <!-- {{document.modified[0].date}}   -->
-        <div *ngIf="document.modified">
+        <div *ngIf="document.modified[0].user">
             <div id="list">               
                 <div id="list-header">  
                     <div class="list-header-field" i18n="@@changes.list.colnames.date">Änderungsdatum</div>
diff --git a/desktop/src/app/components/widgets/changes-history-modal.scss b/desktop/src/app/components/widgets/changes-history-modal.scss
index 12e4369d62..8cf2bea76d 100644
--- a/desktop/src/app/components/widgets/changes-history-modal.scss
+++ b/desktop/src/app/components/widgets/changes-history-modal.scss
@@ -17,7 +17,7 @@
   }
 
   .list-body{    
-    max-height: 70vh;
+    max-height: 66vh;
     overflow: auto;
   }