Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rush does not buill with the latest nightly #16

Open
Marcin-Radecki opened this issue Jul 22, 2024 · 0 comments
Open

Rush does not buill with the latest nightly #16

Marcin-Radecki opened this issue Jul 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Marcin-Radecki
Copy link

Expected behavior

Hi, with the latest nightly toolchain, rush crate stopped to build.

Describe the bug (unexpected behavior)

marcin@marcin-Latitude-3520 ~/g/s/rush (main)> cargo build --release                                                                 (base) 
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2024-07-22, rust version 1.82.0-nightly (92c6c0380 2024-07-21)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'rust-docs'
info: installing component 'rust-std'
info: installing component 'rustc'
info: installing component 'rustfmt'
warning: `/home/marcin/git/synthetic-network/rush/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
   Compiling libc v0.2.68
   Compiling proc-macro2 v1.0.24
   Compiling unicode-xid v0.2.1
   Compiling syn v1.0.60
   Compiling getrandom v0.2.2
   Compiling cfg-if v1.0.0
   Compiling memchr v2.5.0
   Compiling serde_derive v1.0.123
   Compiling serde v1.0.123
   Compiling ryu v1.0.5
   Compiling ppv-lite86 v0.2.10
   Compiling serde_json v1.0.62
   Compiling signal-hook v0.3.6
   Compiling byteorder v1.3.4
   Compiling itoa v0.4.7
   Compiling regex-syntax v0.6.29
   Compiling once_cell v1.3.1
   Compiling aho-corasick v0.7.20
   Compiling quote v1.0.9
   Compiling signal-hook-registry v1.3.0
   Compiling rand_core v0.6.2
   Compiling rand_chacha v0.3.0
   Compiling rand v0.8.3
   Compiling regex v1.7.3
   Compiling rush v0.1.0 (/home/marcin/git/synthetic-network/rush)
warning: found module declaration for lib.rs
 --> src/main.rs:9:1
  |
9 | mod lib;
  | ^^^^^^^^
  |
  = note: lib.rs is the root of this crate's library target
  = help: to refer to it from other targets, use the library's name as the path
  = note: `#[warn(special_module_name)]` on by default

warning: creating a shared reference to mutable static is discouraged
  --> src/engine.rs:48:51
   |
48 | pub fn stats() -> &'static EngineStats { unsafe { &STATS } }
   |                                                   ^^^^^^ shared reference to mutable static
   |
   = note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
   = note: this will be a hard error in the 2024 edition
   = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior
   = note: `#[warn(static_mut_refs)]` on by default
help: use `addr_of!` instead to create a raw pointer
   |
48 | pub fn stats() -> &'static EngineStats { unsafe { addr_of!(STATS) } }
   |                                                   ~~~~~~~~~     +

warning: creating a shared reference to mutable static is discouraged
  --> src/engine.rs:65:51
   |
65 | pub fn state() -> &'static EngineState { unsafe { &STATE } }
   |                                                   ^^^^^^ shared reference to mutable static
   |
   = note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
   = note: this will be a hard error in the 2024 edition
   = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior
help: use `addr_of!` instead to create a raw pointer
   |
65 | pub fn state() -> &'static EngineState { unsafe { addr_of!(STATE) } }
   |                                                   ~~~~~~~~~     +

warning: creating a mutable reference to mutable static is discouraged
   --> src/engine.rs:147:26
    |
147 |     let state = unsafe { &mut STATE };
    |                          ^^^^^^^^^^ mutable reference to mutable static
    |
    = note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
    = note: this will be a hard error in the 2024 edition
    = note: this mutable reference has lifetime `'static`, but if the static gets accessed (read or written) by any other means, or any other reference is created, then any further use of this mutable reference is Undefined Behavior
help: use `addr_of_mut!` instead to create a raw pointer
    |
147 |     let state = unsafe { addr_of_mut!(STATE) };
    |                          ~~~~~~~~~~~~~     +

warning: variable does not need to be mutable
   --> src/flow.rs:240:9
    |
240 |     let mut slot = unsafe { &mut (*map).slots[flow_slot(id)] };
    |         ----^^^^
    |         |
    |         help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

error: avoid using labels containing only the digits `0` and `1` in inline assembly
  --> src/checksum.rs:70:1
   |
70 | 1:
   | ^ use a different label that doesn't start with `0` or `1`
   |
   = help: start numbering with `2` instead
   = note: an LLVM bug makes these labels ambiguous with a binary literal number on x86
   = note: see <https://github.com/llvm/llvm-project/issues/99547> for more information
   = note: `#[deny(binary_asm_labels)]` on by default

warning: `rush` (bin "rush") generated 5 warnings
error: could not compile `rush` (bin "rush") due to 1 previous error; 5 warnings emitted

Steps to reproduce

Screenshots

System information

  • Device: Dell Latitude 3520
  • OS, version: Ubuntu 22.04
  • Browser, version: not related
  • Docker version: not related
  • VNC (if applicable): not related

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant