Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-looker] Use Looker API translator instance in spec loader and state-backed defs #26743

Open
wants to merge 2 commits into
base: maxime/move-translator-context-to-translator-props-class-looker
Choose a base branch
from

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Dec 27, 2024

Summary & Motivation

Same as #26734 but for Looker.

How I Tested These Changes

BK

Changelog

[dagster-looker] load_looker_asset_specs and build_looker_pdt_assets_definitions are updated to accept an instance of DagsterLookerApiTranslator or custom subclass.

Copy link
Contributor Author

maximearmstrong commented Dec 27, 2024

@maximearmstrong maximearmstrong self-assigned this Dec 27, 2024
@maximearmstrong maximearmstrong marked this pull request as ready for review December 27, 2024 20:17
Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is a breaking change, we'd need to wait for dagster 1.10 in order to merge this.

I think the better option here is to make the type Union[DagsterLookerApiTranslator, Type[DagsterLookerApiTranslator]], and emit a deprecation warning if a Type is passed in

Edit: looks like a lot of the related PRs also have breaking changes, so maybe the plan was already to just wait for 1.10 to merge them all, is that right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants