From 5f1f7618c529dfd2975f6f2f858afca02d2d52e1 Mon Sep 17 00:00:00 2001 From: nightwnvol Date: Mon, 15 Dec 2025 11:26:18 +0100 Subject: [PATCH 1/2] fix: remove isExvivo parameter from CylinderZeppelinBall model --- amico/models.pyx | 5 ----- 1 file changed, 5 deletions(-) diff --git a/amico/models.pyx b/amico/models.pyx index d7340c6..6bfde76 100644 --- a/amico/models.pyx +++ b/amico/models.pyx @@ -432,7 +432,6 @@ class CylinderZeppelinBall( BaseModel ) : params['Rs'] = self.Rs params['d_perps'] = self.d_perps params['d_isos'] = self.d_isos - params['isExvivo'] = self.isExvivo return params @@ -546,16 +545,12 @@ class CylinderZeppelinBall( BaseModel ) : def _fit(self, thread_id, y, dirs, hash_table, kernels): # configs cdef int thread_id_c = thread_id - cdef bint is_exvivo = 1 if self.isExvivo else 0 cdef bint compute_rmse = 1 if self.configs['compute_rmse'] else 0 cdef bint compute_nrmse = 1 if self.configs['compute_nrmse'] else 0 cdef int n_rs = len(self.Rs) cdef int n_perp = len(self.d_perps) cdef int n_iso = len(self.d_isos) cdef int n_atoms = n_rs + n_perp + n_iso - # NOTE not implemented - if is_exvivo: - n_atoms += 1 # solver params cdef double lambda1 = self.solver_params['lambda1'] From 296a296e9fa49428d215f3d735ff8b15f7ff42dc Mon Sep 17 00:00:00 2001 From: nightwnvol Date: Mon, 15 Dec 2025 11:26:34 +0100 Subject: [PATCH 2/2] docs: update CHANGELOG.md --- CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 13354d6..7631ac0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,13 @@ # Change Log ### All notable changes to `AMICO` will be documented in this file. +## [Unreleased] +### 🐛Fixed +- Removed `isExvivo` parameter from CylinderZeppelinBall model + +--- +--- + ## `v2.1.1`
_2025-08-13_ ### 🐛Fixed - `UserWarning`: `pkg_resources` is deprecated as an API.