Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support patch comments inline with code #79

Open
gsaslis opened this issue Sep 21, 2023 · 0 comments
Open

Support patch comments inline with code #79

gsaslis opened this issue Sep 21, 2023 · 0 comments
Labels
enhancement New feature extending the app's current capabilities

Comments

@gsaslis
Copy link
Collaborator

gsaslis commented Sep 21, 2023

In order to support a better code review experience, it is useful to add inline comments and start threads on specific lines, focusing the discussion around specific code changes.

This is made possible by clicking a '+' or 💬 next to a line (only for lines that have changed in the Patch), as can be seen also in the screenshot below from the gitlab workflow extension.

Image

I am also including a screenshot from the github extension, but that includes additional functionality we don't want to add at this point in time

Image

@gsaslis gsaslis converted this from a draft issue Sep 21, 2023
@gsaslis gsaslis added the enhancement New feature extending the app's current capabilities label Sep 21, 2023
@gsaslis gsaslis moved this from 📋 Up Next to 🆕 Backlog in Radicle VS Code Extension Sep 21, 2023
@gsaslis gsaslis moved this from 🆕 Backlog to 📋 Up Next in Radicle VS Code Extension Sep 21, 2023
@gsaslis gsaslis moved this from 📋 Up Next to 🆕 Backlog in Radicle VS Code Extension Sep 21, 2023
@maninak maninak changed the title Radicle Patch Overview: Add inline comments Radicle Patch Detail View: Add inline comments Dec 15, 2023
@maninak maninak changed the title Radicle Patch Detail View: Add inline comments Support patch comments inline with code Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature extending the app's current capabilities
Projects
Status: 🆕 Backlog
Development

No branches or pull requests

1 participant