use regex to replace unicode quotes in electron switches

Author: AtofStryker

packages/server/lib/append_electron_switches.ts

@@ -36,14 +36,8 @@ export const appendElectronSwitches = (app: Electron.App) => {
         // thus we don't have to worry about casting
         // --foo=false for example will be "--foo", "false"
         if (value.length) {
-          let joinedValues = value.join('=')
-
           // check if the arg is wrapped in " or ' (unicode)
-          const isWrappedInQuotes = !!['\u0022', '\u0027'].find(((charAsUnicode) => joinedValues.startsWith(charAsUnicode) && joinedValues.endsWith(charAsUnicode)))
-
-          if (isWrappedInQuotes) {
-            joinedValues = joinedValues.slice(1, -1)
-          }
+          const joinedValues = value.join('=').replace(/^(?:['"](.*)['"]|\u0022(.*)\u0027)$/, '$1$2')
 
           app.commandLine.appendSwitch(key, joinedValues)
         } else {

packages/server/test/unit/append_electron_switches_spec.ts

@@ -98,7 +98,7 @@ describe('lib/append_electron_switches', () => {
         commandLine: {
           appendSwitch: sinon.stub(),
         },
-      } as Electron.App
+      } as unknown as Electron.App
 
       appendElectronSwitches(mockApp)
 
@@ -118,7 +118,7 @@ describe('lib/append_electron_switches', () => {
         commandLine: {
           appendSwitch: sinon.stub(),
         },
-      } as Electron.App
+      } as unknown as Electron.App
 
       appendElectronSwitches(mockApp)
       expect(mockApp.commandLine.appendSwitch).to.have.been.calledWith('--foo')