-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reconciliation timestamp to the Module CRD #430
Comments
Hey @petar-cvit, I'm interested in this issue. Could you please assign it to me? 🙇🏻♂️ |
@SpiffyEight77 do you have any updates on the issue? |
@petar-cvit |
@petar-cvit I could work on this issue
|
@Abiji-2020 yup, that sounds good. Just make sure that after you update the struct in go, you generate the manifests using |
Hey @Abiji-2020, do you have any updates on the issue? Let me know if you have any questions |
I have a doubt that currently before updating the code I tried to run the Makefile to generate but it is giving me nil pointer error and with no further details. So I am struck in that process |
Hey @Abiji-2020, thanks for bringing this up. There is a mismatch between go and controller-gen versions. I bumped the controller-gen version in #540. Sync your fork and pull the latest main branch. To install a new version and generate manifests, run the following commands from the Remove previous controller-gen:
Install the new version:
and then you can generate code ( |
oh okay, I was a beginner so I was wondering whether I am doing anything wrong here
|
Is your feature request related to a problem? Please describe.
There is currently reconciliation status on the Module CRD, but another useful information to add to the status would be to add the time when the reconciliation finished. Also, the time should be then propagated to the history entry.
Describe the solution you'd like
As a solution, we should add a new field to the reconciliation status and map it when setting the status of the module after reconciliation.
The text was updated successfully, but these errors were encountered: