Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing a OR operator. #30

Open
thanhbinh89 opened this issue Oct 27, 2021 · 1 comment
Open

Missing a OR operator. #30

thanhbinh89 opened this issue Oct 27, 2021 · 1 comment

Comments

@thanhbinh89
Copy link

freemodbus/modbus/functions/mbfuncholding.c

Line 185 in f167010

usRegCount = ( USHORT )( pucFrame[MB_PDU_FUNC_READ_REGCNT_OFF + 1] );

It should be usRegCount |= ( USHORT )( pucFrame[MB_PDU_FUNC_READ_REGCNT_OFF + 1] );
@ntfreak
Copy link

ntfreak commented May 26, 2022

see https://github.com/cwalter-at/freemodbus/pull/4/files

mcurry-va pushed a commit to VolutionGroup/freemodbus that referenced this issue Mar 13, 2023
As per cwalter-at#30 / https://github.com/cwalter-at/freemodbus/pull/…
924db33 
…4/files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ntfreak @thanhbinh89