Skip to content

Unpin vscode version in CI test workflow #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndreasArvidsson opened this issue Mar 28, 2025 · 0 comments
Open

Unpin vscode version in CI test workflow #2878

AndreasArvidsson opened this issue Mar 28, 2025 · 0 comments

Comments

@AndreasArvidsson
Copy link
Member

With the introduction off vscode 1.98.0 our test workflow is now crashing on mac and Linux. For now I have pinned the vscode version to 1.97.2 for these platforms. We need to figure out a way to go back to testing on stable/latest vscode version.

More information here
#2871

@AndreasArvidsson AndreasArvidsson changed the title Unpin vscode version in test workflow Unpin vscode version in CI test workflow Mar 28, 2025
github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2025
ci crashes. Attempting to fix it

- windows works fine, mac and Linux fails
- vscode 1.97.2 works, 1.98.0 doesn't. There is a new version of
electron between these.
- Updating dependency versions in general hasn't worked
- We're already on latest test-electron
- Removing launchArgs does nothing
- increase memory (--max-old-space-size=8192) doesn't work
- since I'm on windows I can't recreate this problem locally. I don't
know if this is a git have workflow problem or not. I would need help
with testing on other platforms. @phillco @pokey
- Disabling recorded OR scope tests fixes the problem. This could
possibly be an issue with run time or memory usage?
- The only thing that's working is to clamp the version on mac and Linux
to `1.97.2`
- Issue about reverting to stable/latest version
#2878

This is the ending of the verbose log
```
2025-03-09T09:34:49.7876720Z   �[32m  �[32m✔�[39m�[0m�[90m scopes/lua/value.assignment�[0m�[31m (112ms)�[0m
2025-03-09T09:34:49.9693910Z   �[32m  �[32m✔�[39m�[0m�[90m scopes/lua/value.variable�[0m�[31m (161ms)�[0m
2025-03-09T09:34:50.5912000Z �[91m[main 2025-03-09T09:34:50.585Z]�[0m [UtilityProcess id: 1, type: extensionHost, pid: 9199]: crashed with code 5 and reason 'crashed'
2025-03-09T09:34:50.5912990Z �[90m[main 2025-03-09T09:34:50.582Z]�[0m Extension host with pid 9199 exited with code: 5, signal: unknown.
2025-03-09T09:34:50.6309030Z Extension host test runner error { name: �[32m'Canceled'�[39m }
2025-03-09T09:34:50.6309510Z Asking native host service to exit with code 5.
2025-03-09T09:34:50.8105800Z Exit code:   5
2025-03-09T09:34:50.8207260Z Test run threw exception:
2025-03-09T09:34:50.8890080Z TestRunFailedError: Test run failed with code 5
2025-03-09T09:34:50.8891650Z     at ChildProcess.onProcessClosed (/Users/runner/work/cursorless/cursorless/node_modules/�[4m.pnpm�[24m/@VScode[email protected]/node_modules/�[4m@vscode�[24m/test-electron/out/runTest.js:110:24)
2025-03-09T09:34:50.8892590Z �[90m    at ChildProcess.emit (node:events:519:28)�[39m
2025-03-09T09:34:50.8893170Z �[90m    at ChildProcess._handle.onexit (node:internal/child_process:294:12)�[39m {
2025-03-09T09:34:50.8893580Z   code: �[33m5�[39m,
2025-03-09T09:34:50.8893780Z   signal: �[90mundefined�[39m
2025-03-09T09:34:50.8894040Z }
2025-03-09T09:34:50.9196360Z /Users/runner/work/cursorless/cursorless/packages/test-harness:
2025-03-09T09:34:50.9197660Z �[41m�[30m ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL �[39m�[49m �[31m@cursorless/[email protected] test: `env CURSORLESS_MODE=test my-ts-node src/scripts/runVscodeTestsCI.ts`�[39m
2025-03-09T09:34:50.9198230Z �[31mExit status 1�[39m
2025-03-09T09:34:50.9604460Z �[41m�[30m ELIFECYCLE �[39m�[49m �[31mTest failed. See above for more details.�[39m
2025-03-09T09:34:50.9904060Z ##[error]Process completed with exit code 1.
2025-03-09T09:34:51.0082280Z ##[group]Run actions/upload-artifact@v4
2025-03-09T09:34:51.0082530Z with:
2025-03-09T09:34:51.0082660Z   name: logs
2025-03-09T09:34:51.0082860Z   path: /Users/runner/work/cursorless/cursorless/artifacts/logs
2025-03-09T09:34:51.0083130Z   if-no-files-found: warn
2025-03-09T09:34:51.0083290Z   compression-level: 6
2025-03-09T09:34:51.0083430Z   overwrite: false
2025-03-09T09:34:51.0083580Z   include-hidden-files: false
2025-03-09T09:34:51.0083740Z env:
2025-03-09T09:34:51.0083850Z   APP_VERSION: stable
2025-03-09T09:34:51.0084000Z   NEOVIM_VERSION: stable
2025-03-09T09:34:51.0084250Z   VSCODE_CRASH_DIR: /Users/runner/work/cursorless/cursorless/artifacts/dumps
2025-03-09T09:34:51.0084620Z   VSCODE_LOGS_DIR: /Users/runner/work/cursorless/cursorless/artifacts/logs
2025-03-09T09:34:51.0084950Z   CURSORLESS_REPO_ROOT: /Users/runner/work/cursorless/cursorless
2025-03-09T09:34:51.0085250Z   TEMP_DIR: /Users/runner/work/cursorless/cursorless/temp
2025-03-09T09:34:51.0085530Z   NODE_OPTIONS: --max-old-space-size=4096
2025-03-09T09:34:51.0085760Z   PNPM_HOME: /Users/runner/setup-pnpm/node_modules/.bin
2025-03-09T09:34:51.0085980Z ##[endgroup]
2025-03-09T09:34:51.6386700Z ##[warning]No files were found with the provided path: /Users/runner/work/cursorless/cursorless/artifacts/logs. No artifacts will be uploaded.
2025-03-09T09:34:51.6563360Z ##[group]Run actions/upload-artifact@v4
2025-03-09T09:34:51.6563590Z with:
2025-03-09T09:34:51.6563780Z   name: dumps
2025-03-09T09:34:51.6564000Z   path: /Users/runner/work/cursorless/cursorless/artifacts/dumps
2025-03-09T09:34:51.6564280Z   if-no-files-found: warn
2025-03-09T09:34:51.6564470Z   compression-level: 6
2025-03-09T09:34:51.6564630Z   overwrite: false
2025-03-09T09:34:51.6564920Z   include-hidden-files: false
2025-03-09T09:34:51.6565080Z env:
2025-03-09T09:34:51.6565190Z   APP_VERSION: stable
2025-03-09T09:34:51.6565630Z   NEOVIM_VERSION: stable
2025-03-09T09:34:51.6565870Z   VSCODE_CRASH_DIR: /Users/runner/work/cursorless/cursorless/artifacts/dumps
2025-03-09T09:34:51.6566250Z   VSCODE_LOGS_DIR: /Users/runner/work/cursorless/cursorless/artifacts/logs
2025-03-09T09:34:51.6566630Z   CURSORLESS_REPO_ROOT: /Users/runner/work/cursorless/cursorless
2025-03-09T09:34:51.6566950Z   TEMP_DIR: /Users/runner/work/cursorless/cursorless/temp
2025-03-09T09:34:51.6567350Z   NODE_OPTIONS: --max-old-space-size=4096
2025-03-09T09:34:51.6567590Z   PNPM_HOME: /Users/runner/setup-pnpm/node_modules/.bin
2025-03-09T09:34:51.6567820Z ##[endgroup]
2025-03-09T09:34:51.8704200Z ##[warning]No files were found with the provided path: /Users/runner/work/cursorless/cursorless/artifacts/dumps. No artifacts will be uploaded.
2025-03-09T09:34:51.8773560Z Post job cleanup.
2025-03-09T09:34:52.0017680Z Pruning is unnecessary.
2025-03-09T09:34:52.0089960Z Post job cleanup.
2025-03-09T09:34:52.1354750Z [command]/opt/homebrew/bin/git version
2025-03-09T09:34:52.1550650Z git version 2.48.1
2025-03-09T09:34:52.1581040Z Copying '/Users/runner/.gitconfig' to '/Users/runner/work/_temp/1769469e-74d1-4231-9672-6568217dd45e/.gitconfig'
2025-03-09T09:34:52.1587940Z Temporarily overriding HOME='/Users/runner/work/_temp/1769469e-74d1-4231-9672-6568217dd45e' before making global git config changes
2025-03-09T09:34:52.1588770Z Adding repository directory to the temporary git global config as a safe directory
2025-03-09T09:34:52.1592000Z [command]/opt/homebrew/bin/git config --global --add safe.directory /Users/runner/work/cursorless/cursorless
2025-03-09T09:34:52.1706600Z [command]/opt/homebrew/bin/git config --local --name-only --get-regexp core\.sshCommand
2025-03-09T09:34:52.1766580Z [command]/opt/homebrew/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
2025-03-09T09:34:52.4941450Z [command]/opt/homebrew/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2025-03-09T09:34:52.4980380Z http.https://github.com/.extraheader
2025-03-09T09:34:52.5198820Z [command]/opt/homebrew/bin/git config --local --unset-all http.https://github.com/.extraheader
2025-03-09T09:34:52.5267670Z [command]/opt/homebrew/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
2025-03-09T09:34:52.5845790Z Cleaning up orphan processes
2025-03-09T09:34:52.6448380Z Terminate orphan process: pid (9697) (Code Helper (Pl)
2025-03-09T09:34:52.6734230Z Terminate orphan process: pid (9438) (Code Helper (Pl)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant