Skip to content

Commit f109747

Browse files
Rename OneOfScopeHandler to SortedScopeHandler (#2831)
Fixes #2790
1 parent ba1c166 commit f109747

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

Diff for: packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/CollectionItemScopeHandler/CollectionItemScopeHandler.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import type {
66
} from "@cursorless/common";
77
import type { LanguageDefinitions } from "../../../../languages/LanguageDefinitions";
88
import { BaseScopeHandler } from "../BaseScopeHandler";
9-
import { OneOfScopeHandler } from "../OneOfScopeHandler";
9+
import { SortedScopeHandler } from "../SortedScopeHandler";
1010
import type { TargetScope } from "../scope.types";
1111
import type {
1212
ComplexScopeType,
@@ -46,7 +46,7 @@ export class CollectionItemScopeHandler extends BaseScopeHandler {
4646
return textualScopeHandler;
4747
}
4848

49-
return OneOfScopeHandler.createFromScopeHandlers(
49+
return SortedScopeHandler.createFromScopeHandlers(
5050
scopeHandlerFactory,
5151
languageId,
5252
[languageScopeHandler, textualScopeHandler],

Diff for: packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/NotebookCellScopeHandler.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
import type { LanguageDefinitions } from "../../../languages/LanguageDefinitions";
88
import { BaseScopeHandler } from "./BaseScopeHandler";
99
import { NotebookCellApiScopeHandler } from "./NotebookCellApiScopeHandler";
10-
import { OneOfScopeHandler } from "./OneOfScopeHandler";
10+
import { SortedScopeHandler } from "./SortedScopeHandler";
1111
import type { TargetScope } from "./scope.types";
1212
import type {
1313
ComplexScopeType,
@@ -44,7 +44,7 @@ export class NotebookCellScopeHandler extends BaseScopeHandler {
4444
return apiScopeHandler;
4545
}
4646

47-
return OneOfScopeHandler.createFromScopeHandlers(
47+
return SortedScopeHandler.createFromScopeHandlers(
4848
scopeHandlerFactory,
4949
languageId,
5050
[languageScopeHandler, apiScopeHandler],

Diff for: packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/ScopeHandlerFactoryImpl.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { FallbackScopeHandler } from "./FallbackScopeHandler";
1212
import { IdentifierScopeHandler } from "./IdentifierScopeHandler";
1313
import { LineScopeHandler } from "./LineScopeHandler";
1414
import { NotebookCellScopeHandler } from "./NotebookCellScopeHandler";
15-
import { OneOfScopeHandler } from "./OneOfScopeHandler";
15+
import { SortedScopeHandler } from "./SortedScopeHandler";
1616
import { ParagraphScopeHandler } from "./ParagraphScopeHandler";
1717
import {
1818
CustomRegexScopeHandler,
@@ -130,7 +130,7 @@ export class ScopeHandlerFactoryImpl implements ScopeHandlerFactory {
130130
case "custom":
131131
return scopeType.scopeHandler;
132132
case "oneOf":
133-
return OneOfScopeHandler.create(this, scopeType, languageId);
133+
return SortedScopeHandler.create(this, scopeType, languageId);
134134
case "fallback":
135135
return FallbackScopeHandler.create(this, scopeType, languageId);
136136
case "conditional":

Diff for: packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/OneOfScopeHandler.ts renamed to packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/SortedScopeHandler.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ import type {
1515
ScopeIteratorRequirements,
1616
} from "./scopeHandler.types";
1717

18-
export class OneOfScopeHandler extends BaseScopeHandler {
18+
export class SortedScopeHandler extends BaseScopeHandler {
1919
protected isHierarchical = true;
2020
public scopeType = undefined;
21-
private iterationScopeHandler: OneOfScopeHandler | undefined;
21+
private iterationScopeHandler: SortedScopeHandler | undefined;
2222
private lastYieldedIndex: number | undefined;
2323

2424
static create(
@@ -43,7 +43,7 @@ export class OneOfScopeHandler extends BaseScopeHandler {
4343
scopeHandlers: ScopeHandler[],
4444
): ScopeHandler {
4545
const getIterationScopeHandler = () =>
46-
new OneOfScopeHandler(
46+
new SortedScopeHandler(
4747
scopeHandlers.map((scopeHandler) =>
4848
scopeHandlerFactory.create(
4949
scopeHandler.iterationScopeType,
@@ -55,12 +55,12 @@ export class OneOfScopeHandler extends BaseScopeHandler {
5555
},
5656
);
5757

58-
return new OneOfScopeHandler(scopeHandlers, getIterationScopeHandler);
58+
return new SortedScopeHandler(scopeHandlers, getIterationScopeHandler);
5959
}
6060

6161
private constructor(
6262
private scopeHandlers: ScopeHandler[],
63-
private getIterationScopeHandler: () => OneOfScopeHandler,
63+
private getIterationScopeHandler: () => SortedScopeHandler,
6464
) {
6565
super();
6666
}

Diff for: packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/InteriorScopeHandler.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import type { Target } from "../../../../typings/target.types";
1212
import { InteriorTarget } from "../../../targets";
1313
import { BaseScopeHandler } from "../BaseScopeHandler";
1414
import { FallbackScopeHandler } from "../FallbackScopeHandler";
15-
import { OneOfScopeHandler } from "../OneOfScopeHandler";
15+
import { SortedScopeHandler } from "../SortedScopeHandler";
1616
import type { TargetScope } from "../scope.types";
1717
import type {
1818
ComplexScopeType,
@@ -98,7 +98,7 @@ export class InteriorScopeHandler extends BaseScopeHandler {
9898
return pairScopeHandler;
9999
}
100100

101-
return OneOfScopeHandler.createFromScopeHandlers(
101+
return SortedScopeHandler.createFromScopeHandlers(
102102
this.scopeHandlerFactory,
103103
this.languageId,
104104
[languageScopeHandler, pairScopeHandler],

Diff for: packages/cursorless-engine/src/processTargets/modifiers/scopeHandlers/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export * from "./WordScopeHandler/WordScopeHandler";
66
export * from "./TokenScopeHandler";
77
export * from "./DocumentScopeHandler";
88
export * from "./TreeSitterScopeHandler";
9-
export * from "./OneOfScopeHandler";
9+
export * from "./SortedScopeHandler";
1010
export * from "./ParagraphScopeHandler";
1111
export * from "./SentenceScopeHandler/SentenceScopeHandler";
1212
export * from "./RegexScopeHandler";

0 commit comments

Comments
 (0)