Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement Swap action #93

Open
Omicrxn opened this issue Aug 30, 2024 · 3 comments
Open

[Feature] Implement Swap action #93

Omicrxn opened this issue Aug 30, 2024 · 3 comments
Milestone

Comments

@Omicrxn
Copy link

Omicrxn commented Aug 30, 2024

Based on the image below, if from left to right the GridItems are 1 (blob) ,2 (party dog) and 3 (ice cream), In case I'd like to swap Item 1 for Item 3, when dragging Item 1 on top of Item 2, It would push Item 2. I'd like the behaviour to only swap Item 1 for Item 3 without pushing Item 2. An excellent behaviour in my opinion would be to do the swap if the dragged element is on top of the element to swap for 1 second or some time that feels right. This library for example has a great behaviour https://swapy.tahazsh.com/

I know there are some edge cases regarding size and position but maybe we can choose wether in case the size doesn't match we could push the element, or cancel the drop or something. The annoying behaviour is just when you are dragging on top of an element which you don't even want to move
image

@cuire
Copy link
Owner

cuire commented Aug 30, 2024

Amazing idea, I like it ❤️ Added to v2 milestone

@cuire cuire assigned cuire and unassigned cuire Aug 30, 2024
@cuire cuire added this to the 2.0.0 milestone Aug 30, 2024
@Omicrxn
Copy link
Author

Omicrxn commented Aug 30, 2024

awesome! just out of curiosity, what time expectation do you have for v2.

@cuire
Copy link
Owner

cuire commented Aug 30, 2024

awesome! just out of curiosity, what time expectation do you have for v2.

I dont have any tbh. I just changed jobs and it takes a lot of time for onboarding. At least Ill try to write all ideas in a form of issues in a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants