-
Notifications
You must be signed in to change notification settings - Fork 313
ci: pull every commit through the proxy #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm slightly confused; don't we already do this in cue/internal/ci/github/trybot.cue Line 89 in 9e9786e
|
Hmm good spot. To be honest I didn't check, and instead assumed we were only doing this for semantic versions. Because this is the kind of thing I see locally:
6.7s to resolve a commit that has already been pulled through the proxy. I'll raise this as a Go issue to see if there's anything up with the proxy. Thanks for catching this. |
The Go issue for completeness golang/go#54977 |
Just a guess, but that is a fairly old commit. I wouldn't be surprised if their caching mechanism didn't keep every single VCS ref around for quick resolution forever. Perhaps they get kicked out of the cache if unused for a few weeks. |
To be clear, by fairly old I mean that https://review.gerrithub.io/c/cue-lang/cue/+/529524 was submitted in late June, meaning that it's been over two months since we last pulled this commit through the proxy in CI. |
I did a |
Is your feature request related to a problem? Please describe.
When running
go get cuelang.org/go@$commit
via proxy.golang.org, it generally takes a long time to resolve because the proxy has to resolve from that commit to a pseudo-version. Later requests are cached, so much faster. This makes testing, creating repros etc more painful.Describe the solution you'd like
go get cuelang.org/go@$commit
to be run as part of CI for each new commit onmaster
.Describe alternatives you've considered
Running this myself, but it's better placed in CI as part of the build for each new commit on tip.
Additional context
n/a
The text was updated successfully, but these errors were encountered: