Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog latest should work for unreleased projects #12

Open
mpkorstanje opened this issue May 22, 2022 · 1 comment
Open

changelog latest should work for unreleased projects #12

mpkorstanje opened this issue May 22, 2022 · 1 comment

Comments

@mpkorstanje
Copy link

mpkorstanje commented May 22, 2022

👓 What did you see?

# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Added
- First release of polyglot-release
mpkorstanje@Nyx:~/Projects/cucumber/polyglot-release$ changelog latest
Error: There are no released versions in the changelog yet
There are no released versions in the changelog yet
mpkorstanje@Nyx:~/Projects/cucumber/polyglot-release$ echo $?
1

By exiting with 1 we can not determine if there was a problem in the changelog or simply no version. This makes it impossible to use changelog in conjuction with automated tooling to make a first release (i.e. cucumber/polyglot-release#68).

✅ What did you expect to see?

Either exit code 0, and an empty string.

📦 Which tool/library version are you using?

Latest version I guess. But see: #11

@mattwynne
Copy link
Member

There's some coupling here to be aware of:

https://github.com/cucumber/action-get-versions/blob/main/entrypoint.sh#L5 works around the current behaviour. If we change this, we could also simplify that code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants