From 2be4a8ec070ce5e811a6578a6a21cf4b32b9de8d Mon Sep 17 00:00:00 2001 From: Ben Isaacs Date: Sun, 14 Feb 2021 16:18:43 +0000 Subject: [PATCH] Add note about how I'm using serialization wrong. --- test/Media_RSS_Item_SerializationTest.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/Media_RSS_Item_SerializationTest.php b/test/Media_RSS_Item_SerializationTest.php index 2c83b12..7cafb42 100644 --- a/test/Media_RSS_Item_SerializationTest.php +++ b/test/Media_RSS_Item_SerializationTest.php @@ -40,6 +40,10 @@ public function test_unserialize_rejects_invalid_serialization_version() $item2 = unserialize($serialized); } + /** + * TODO: I am using serialize/unserialize wrong here. I should unset these properties on load, not save. + * But that would require a version bump in the cache constant. + */ public function test_unserialize_does_not_overwrite_properties_set_from_fs_metadata() { $item = new Media_RSS_Item('example.mp3');