Skip to content

Add Gronsfeld Cipher with Numeric Vigenère Support - #1842

Merged
csxark merged 2 commits into
csxark:mainfrom
karan-chaos:feature/gronsfeld-cipher
Aug 31, 2026
Merged

Add Gronsfeld Cipher with Numeric Vigenère Support#1842
csxark merged 2 commits into
csxark:mainfrom
karan-chaos:feature/gronsfeld-cipher

Conversation

@karan-chaos

Copy link
Copy Markdown
Contributor

closes #1841
Summary:
Implemented the Gronsfeld cipher with digit-only repeating keys and visualizer support.

Changes:

Added Gronsfeld encryption and decryption
Added digit-only key parsing and validation
Added repeating key stream handling
Added instrumented visualizer steps
Added key-stream visualization
Registered the cipher in the type definitions and registry
Added 30+ unit tests covering core functionality and edge cases
Kept changes conflict-free with existing cipher branches

Branch: feature/gronsfeld-cipher
Commit: 9186110

…git-only keys

Implements the Gronsfeld cipher, a numeric variant of the Vigenère cipher
where the key is a sequence of digits (0-9) instead of letters. Features
full encrypt/decrypt with modular arithmetic, repeating key stream
visualization, instrumented visualizer steps with per-character trace
and numeric key display, and comprehensive unit tests including round-trips,
edge cases, and comparison with Vigenère key space.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

@karan-chaos is attempting to deploy a commit to the csxark's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

🎉 Thank You for Your Contribution

Hello @karan-chaos,

Thank you for submitting a Pull Request to CryptoViz. We appreciate the time and effort you've invested in contributing to the project.

Your Pull Request has been received successfully and will be reviewed by the maintainers as soon as possible.

📋 Pull Request Checklist

  • ✅ Linked the related issue
  • ✅ No merge conflicts
  • ✅ Synced with the latest main branch
  • ✅ Build passes successfully
  • ✅ All tests pass

Ensuring these requirements are met helps streamline the review process and enables maintainers to review your contribution more efficiently.

❤️ Support CryptoViz

If you find CryptoViz helpful, consider supporting the project by:

  • ⭐ Starring the repository
  • 🍴 Forking the repository
  • 👤 Following Ark on GitHub
  • 💼 Connecting on LinkedIn
  • 🌐 Visiting the Portfolio

Your support helps increase the project's visibility and encourages continued development. Thank you for being a part of the CryptoViz community!

Thank you once again for contributing to CryptoViz. We appreciate your support and look forward to reviewing your contribution.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 53 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 08c029cb-3194-4084-ae1c-58c59467ed0c

📥 Commits

Reviewing files that changed from the base of the PR and between fa6fdbf and e192609.

📒 Files selected for processing (4)
  • lib/cipher/classical/gronsfeld.ts
  • lib/cipher/registry.ts
  • lib/cipher/types.ts
  • tests/unit/classical/gronsfeld.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…ipher

# Conflicts:
#	lib/cipher/registry.ts
#	lib/cipher/types.ts
@csxark csxark added ECSoC26 Elite Coders Summer of Code 2026 and removed needs review labels Aug 31, 2026
@csxark
csxark merged commit 11fef33 into csxark:main Aug 31, 2026
3 of 9 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Pull Request Merged

Hello @karan-chaos,

Thank you for your contribution to CryptoViz. Your Pull Request has been reviewed and successfully merged into the project.

We sincerely appreciate the time and effort you invested in improving the project. Contributions like yours help make CryptoViz better for the entire community.

We look forward to your future contributions and hope to collaborate with you again.

❤️ Support CryptoViz

If you find CryptoViz helpful, consider supporting the project by:

  • ⭐ Starring the repository
  • 🍴 Forking the repository
  • 👤 Following Ark on GitHub
  • 💼 Connecting on LinkedIn
  • 🌐 Visiting the Portfolio

Your support helps increase the project's visibility and encourages continued development. Thank you for being a part of the CryptoViz community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ECSoC26-L3 ECSoC26 Elite Coders Summer of Code 2026

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Gronsfeld Cipher

2 participants