From c49830b81c2db9341d3fe91302dc02a97f509c37 Mon Sep 17 00:00:00 2001 From: Chris Souers Date: Wed, 2 Oct 2024 00:17:48 -0400 Subject: [PATCH] verify the door ajar stuff --- opendbc/car/honda/carstate.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/opendbc/car/honda/carstate.py b/opendbc/car/honda/carstate.py index 5bef3a0917..9ceb37d829 100644 --- a/opendbc/car/honda/carstate.py +++ b/opendbc/car/honda/carstate.py @@ -134,9 +134,8 @@ def update(self, cp, cp_cam, _, cp_body, __) -> structs.CarState: # panda checks if the signal is non-zero ret.standstill = cp.vl["ENGINE_DATA"]["XMISSION_SPEED"] < 1e-5 # TODO: find a common signal across all cars - # TODO: verify odyssey_bosch if self.CP.carFingerprint in (CAR.HONDA_ACCORD, CAR.HONDA_CIVIC_BOSCH, CAR.HONDA_CIVIC_BOSCH_DIESEL, CAR.HONDA_CRV_HYBRID, CAR.HONDA_INSIGHT, - CAR.ACURA_RDX_3G, CAR.HONDA_E, CAR.HONDA_CIVIC_2022, CAR.HONDA_HRV_3G, CAR.HONDA_ODYSSEY_BOSCH): + CAR.ACURA_RDX_3G, CAR.HONDA_E, CAR.HONDA_CIVIC_2022, CAR.HONDA_HRV_3G): ret.doorOpen = bool(cp.vl["SCM_FEEDBACK"]["DRIVERS_DOOR_OPEN"]) elif self.CP.carFingerprint in (CAR.HONDA_ODYSSEY_CHN, CAR.HONDA_FREED, CAR.HONDA_HRV): ret.doorOpen = bool(cp.vl["SCM_BUTTONS"]["DRIVERS_DOOR_OPEN"]) @@ -145,7 +144,6 @@ def update(self, cp, cp_cam, _, cp_body, __) -> structs.CarState: cp.vl["DOORS_STATUS"]["DOOR_OPEN_RL"], cp.vl["DOORS_STATUS"]["DOOR_OPEN_RR"]]) ret.seatbeltUnlatched = bool(cp.vl["SEATBELT_STATUS"]["SEATBELT_DRIVER_LAMP"] or not cp.vl["SEATBELT_STATUS"]["SEATBELT_DRIVER_LATCHED"]) - # TODO: same on all cars, right? # Triggered by STEER_TORQUE_REQUEST in CAN frame STEERING_CONTROL self.steer_on = bool(cp.vl["STEER_STATUS"]["STEER_CONTROL_ACTIVE"]) steer_status = self.steer_status_values[cp.vl["STEER_STATUS"]["STEER_STATUS"]]