Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should load image from another day if today's image is a video #12

Open
lloydstubber opened this issue Jul 5, 2017 · 3 comments
Open

Should load image from another day if today's image is a video #12

lloydstubber opened this issue Jul 5, 2017 · 3 comments

Comments

@lloydstubber
Copy link

lloydstubber commented Jul 5, 2017 •
edited
Loading

First off, love the plugin! Just wanted to submit this to let you know today's image isn't loading. See screenshot attached.

noimage

Running on:

  • Hyper 1.3.3
  • Windows 10 Pro 1703
  • OS Build 15063.413
  • WSL Bash - Ubuntu 16.04.2 LTS

Cheers!
@lloydstubber
Copy link
Author

Seems like it's working today. Had a look at the NASA post yesterday and it was a video.

@cseale cseale changed the title Not loading image Should load image from another day if today's image is a video Aug 14, 2017
@cseale cseale reopened this Aug 14, 2017
@cseale
Copy link
Owner

cseale commented Aug 14, 2017

I'm reopening this as an issue if anyone decides they want to tackle it. If there is no image for the day, it would be nice to fall back to the next available image and always have something to display

@Booom3
Copy link

Booom3 commented Aug 31, 2018

@cseale
I made a pull request for this
#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Booom3 @cseale @lloydstubber