File tree 3 files changed +12
-7
lines changed
3 files changed +12
-7
lines changed Original file line number Diff line number Diff line change @@ -10,19 +10,22 @@ Here's a quick guide for contributing:
10
10
11
11
1 . Fork the repo.
12
12
13
- 2 . Run the tests. We only take pull requests with passing tests, and it's great
13
+ 1 . Make sure you have ImageMagick and Ghostscript installed. See [ this section]
14
+ (./README.md#image-processor) of the README.
15
+
16
+ 1 . Run the tests. We only take pull requests with passing tests, and it's great
14
17
to know that you have a clean slate: ` bundle && bundle exec rake `
15
18
16
- 3 . Add a test for your change. Only refactoring and documentation changes
19
+ 1 . Add a test for your change. Only refactoring and documentation changes
17
20
require no new tests. If you are adding functionality or fixing a bug, we need
18
21
a test!
19
22
20
- 4 . Make the test pass.
23
+ 1 . Make the test pass.
21
24
22
- 5 . Mention how your changes affect the project to other developers and users in
25
+ 1 . Mention how your changes affect the project to other developers and users in
23
26
the ` NEWS.md ` file.
24
27
25
- 6 . Push to your fork and submit a pull request.
28
+ 1 . Push to your fork and submit a pull request.
26
29
27
30
At this point you're waiting on us. We like to at least comment on, if not
28
31
accept, pull requests within seven business days (most of the work on Paperclip
Original file line number Diff line number Diff line change @@ -944,7 +944,7 @@ guidelines:
944
944
about writing tests for paperclip, please open a
945
945
[GitHub issue](https://github.com/thoughtbot/paperclip/issues/new).
946
946
947
- Please see `CONTRIBUTING.md` for more details on contributing and running test.
947
+ Please see [ `CONTRIBUTING.md`](./CONTRIBUTING.md) for more details on contributing and running test.
948
948
949
949
Thank you to all [the contributors](https://github.com/thoughtbot/paperclip/graphs/contributors)!
950
950
Original file line number Diff line number Diff line change @@ -19,7 +19,9 @@ class MissingRequiredValidatorError < Paperclip::Error
19
19
end
20
20
21
21
# Will be thrown when ImageMagic cannot determine the uploaded file's
22
- # metadata, usually this would mean the file is not an image.
22
+ # metadata, usually this would mean the file is not an image. If you are
23
+ # consistently receiving this error on PDFs make sure that you have
24
+ # installed Ghostscript.
23
25
class NotIdentifiedByImageMagickError < Paperclip ::Error
24
26
end
25
27
You can’t perform that action at this time.
0 commit comments