Merge pull request #5093 from 2403905/issue-11046

2403905 · web-flow · commit d2e98d347add · 2025-02-24T11:08:57.000+01:00
Fix OCM create share
diff --git a/changelog/unreleased/fix-ocm-create-share.md b/changelog/unreleased/fix-ocm-create-share.md
@@ -0,0 +1,6 @@
+Bugfix: Fix OCM create share
+
+We fixed the OCM share fails on share creating if the federated instance is not reachable.
+
+https://github.com/cs3org/reva/pull/5093  
+https://github.com/owncloud/ocis/issues/11046
diff --git a/internal/grpc/services/gateway/ocmshareprovider.go b/internal/grpc/services/gateway/ocmshareprovider.go
@@ -56,6 +56,9 @@ func (s *svc) CreateOCMShare(ctx context.Context, req *ocm.CreateOCMShareRequest
 	if err != nil {
 		return nil, errors.Wrap(err, "gateway: error calling CreateOCMShare")
 	}
+	if res.GetStatus().GetCode() != rpc.Code_CODE_OK {
+		return res, nil
+	}
 
 	// add a grant to the storage provider so the share can efficiently be listed
 	// the grant does not grant any permissions. access is granted by the OCM link token

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,9 @@ func (s svc) CreateOCMShare(ctx context.Context, req ocm.CreateOCMShareRequest`
`56`	`56`	`if err != nil {`
`57`	`57`	`return nil, errors.Wrap(err, "gateway: error calling CreateOCMShare")`
`58`	`58`	`}`
	`59`	`+ if res.GetStatus().GetCode() != rpc.Code_CODE_OK {`
	`60`	`+ return res, nil`
	`61`	`+ }`
`59`	`62`
`60`	`63`	`// add a grant to the storage provider so the share can efficiently be listed`
`61`	`64`	`// the grant does not grant any permissions. access is granted by the OCM link token`