Commit 25797e0
authored
fix: add summary even when failure threshold is surpassed (#285)
Alerts are currently generated by throwing an exception. This means that
all code that comes after that exception is skipped, including generating
the Action summary.
We can easily fix this, by generating the summary first.
Longer term, we might want to reconsider the code style here.
An exception should model something exceptional happening in our code.
Seeing bad benchmark numbers is not exceptional. It's what this tool is
supposed to handle.
Closes benchmark-action/github-action-benchmark#2541 parent e3c6616 commit 25797e0
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
541 | 541 | | |
542 | 542 | | |
543 | 543 | | |
544 | | - | |
545 | 544 | | |
| 545 | + | |
546 | 546 | | |
547 | 547 | | |
548 | 548 | | |
| |||
0 commit comments