Skip to content

Commit 12c5a4f

Browse files
[docs] Fix firebase storage example link and known issue section position in ImagePicker (expo#23007)
1 parent 3858909 commit 12c5a4f

File tree

4 files changed

+23
-19
lines changed

4 files changed

+23
-19
lines changed

docs/pages/versions/unversioned/sdk/imagepicker.mdx

+5-4
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import Video from '~/components/plugins/Video';
1818
import { SnackInline } from '~/ui/components/Snippet';
1919
import { BoxLink } from '~/ui/components/BoxLink';
2020
import { GithubIcon } from '@expo/styleguide-icons';
21+
import { PlatformTags } from '~/ui/components/Tag';
2122

2223
**`expo-image-picker`** provides access to the system's UI for selecting images and videos from the phone's library or taking a photo with the camera.
2324

@@ -29,6 +30,10 @@ import { GithubIcon } from '@expo/styleguide-icons';
2930

3031
<APIInstallSection />
3132

33+
#### Known issues&ensp;<PlatformTags platforms={['ios']} />
34+
35+
On iOS, when an image (usually of a [higher resolution](http://www.openradar.me/49866214)) is picked from the camera roll, the result of the cropped image gives the wrong value for the cropped rectangle in some cases. Unfortunately, this issue is with the underlying `UIImagePickerController` due to a bug in the closed-source tools built into iOS.
36+
3237
## Configuration in app.json/app.config.js
3338

3439
You can configure `expo-image-picker` using its built-in [config plugin](/config-plugins/introduction/) if you use config plugins in your project ([EAS Build](/build/introduction) or `npx expo run:[android|ios]`). The plugin allows you to configure various properties that cannot be set at runtime and require building a new app binary to take effect.
@@ -192,7 +197,3 @@ The following usage description keys are used by the APIs in this library.
192197
'NSCameraUsageDescription',
193198
]}
194199
/>
195-
196-
## Known issue
197-
198-
There is a known issue on iOS with the underlying `UIImagePickerController`. When an image (usually of a [higher resolution](http://www.openradar.me/49866214)) is picked from the camera roll, the result of the cropped image gives the wrong value for the cropped rectangle in some cases. Unfortunately, this issue is due to a bug in the closed source tools built into iOS.

docs/pages/versions/v46.0.0/sdk/imagepicker.mdx

+6-5
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import Video from '~/components/plugins/Video';
1818
import { SnackInline } from '~/ui/components/Snippet';
1919
import { BoxLink } from '~/ui/components/BoxLink';
2020
import { GithubIcon } from '@expo/styleguide-icons';
21+
import { PlatformTags } from '~/ui/components/Tag';
2122

2223
**`expo-image-picker`** provides access to the system's UI for selecting images and videos from the phone's library or taking a photo with the camera.
2324

@@ -29,6 +30,10 @@ import { GithubIcon } from '@expo/styleguide-icons';
2930

3031
<APIInstallSection />
3132

33+
#### Known issues&ensp;<PlatformTags platforms={['ios']} />
34+
35+
On iOS, when an image (usually of a [higher resolution](http://www.openradar.me/49866214)) is picked from the camera roll, the result of the cropped image gives the wrong value for the cropped rectangle in some cases. Unfortunately, this issue is with the underlying `UIImagePickerController` due to a bug in the closed-source tools built into iOS.
36+
3237
## Configuration in app.json/app.config.js
3338

3439
You can configure `expo-image-picker` using its built-in [config plugin](/config-plugins/introduction/) if you use config plugins in your project ([EAS Build](../../../build/introduction.mdx) or `expo run:[android|ios]`). The plugin allows you to configure various properties that cannot be set at runtime and require building a new app binary to take effect.
@@ -148,7 +153,7 @@ See [Amplify documentation](https://docs.amplify.aws/) guide to set up your proj
148153
title="Firebase storage example"
149154
description="An example of how to use Firebase storage can be found in with-firebase-storage-upload."
150155
Icon={GithubIcon}
151-
href="https://github.com/expo/examples/tree/master/with-aws-storage-upload"
156+
href="https://github.com/expo/examples/tree/master/with-firebase-storage-upload"
152157
/>
153158

154159
See [Using Firebase](/guides/using-firebase/) guide to set up your project correctly.
@@ -180,7 +185,3 @@ The following usage description keys are used by the APIs in this library.
180185
'NSCameraUsageDescription',
181186
]}
182187
/>
183-
184-
## Known issue
185-
186-
There is a known issue on iOS with the underlying `UIImagePickerController`. When an image (usually of a [higher resolution](http://www.openradar.me/49866214)) is picked from the camera roll, the result of the cropped image gives the wrong value for the cropped rectangle in some cases. Unfortunately, this issue is due to a bug in the closed source tools built into iOS.

docs/pages/versions/v47.0.0/sdk/imagepicker.mdx

+6-5
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import Video from '~/components/plugins/Video';
1818
import { SnackInline } from '~/ui/components/Snippet';
1919
import { BoxLink } from '~/ui/components/BoxLink';
2020
import { GithubIcon } from '@expo/styleguide-icons';
21+
import { PlatformTags } from '~/ui/components/Tag';
2122

2223
**`expo-image-picker`** provides access to the system's UI for selecting images and videos from the phone's library or taking a photo with the camera.
2324

@@ -29,6 +30,10 @@ import { GithubIcon } from '@expo/styleguide-icons';
2930

3031
<APIInstallSection />
3132

33+
#### Known issues&ensp;<PlatformTags platforms={['ios']} />
34+
35+
On iOS, when an image (usually of a [higher resolution](http://www.openradar.me/49866214)) is picked from the camera roll, the result of the cropped image gives the wrong value for the cropped rectangle in some cases. Unfortunately, this issue is with the underlying `UIImagePickerController` due to a bug in the closed-source tools built into iOS.
36+
3237
## Configuration in app.json/app.config.js
3338

3439
You can configure `expo-image-picker` using its built-in [config plugin](/config-plugins/introduction/) if you use config plugins in your project ([EAS Build](/build/introduction) or `npx expo run:[android|ios]`). The plugin allows you to configure various properties that cannot be set at runtime and require building a new app binary to take effect.
@@ -160,7 +165,7 @@ See [Amplify documentation](https://docs.amplify.aws/) guide to set up your proj
160165
title="Firebase storage example"
161166
description="An example of how to use Firebase storage can be found in with-firebase-storage-upload."
162167
Icon={GithubIcon}
163-
href="https://github.com/expo/examples/tree/master/with-aws-storage-upload"
168+
href="https://github.com/expo/examples/tree/master/with-firebase-storage-upload"
164169
/>
165170

166171
See [Using Firebase](/guides/using-firebase/) guide to set up your project correctly.
@@ -192,7 +197,3 @@ The following usage description keys are used by the APIs in this library.
192197
'NSCameraUsageDescription',
193198
]}
194199
/>
195-
196-
## Known issue
197-
198-
There is a known issue on iOS with the underlying `UIImagePickerController`. When an image (usually of a [higher resolution](http://www.openradar.me/49866214)) is picked from the camera roll, the result of the cropped image gives the wrong value for the cropped rectangle in some cases. Unfortunately, this issue is due to a bug in the closed source tools built into iOS.

docs/pages/versions/v48.0.0/sdk/imagepicker.mdx

+6-5
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import Video from '~/components/plugins/Video';
1818
import { SnackInline } from '~/ui/components/Snippet';
1919
import { BoxLink } from '~/ui/components/BoxLink';
2020
import { GithubIcon } from '@expo/styleguide-icons';
21+
import { PlatformTags } from '~/ui/components/Tag';
2122

2223
**`expo-image-picker`** provides access to the system's UI for selecting images and videos from the phone's library or taking a photo with the camera.
2324

@@ -29,6 +30,10 @@ import { GithubIcon } from '@expo/styleguide-icons';
2930

3031
<APIInstallSection />
3132

33+
#### Known issues&ensp;<PlatformTags platforms={['ios']} />
34+
35+
On iOS, when an image (usually of a [higher resolution](http://www.openradar.me/49866214)) is picked from the camera roll, the result of the cropped image gives the wrong value for the cropped rectangle in some cases. Unfortunately, this issue is with the underlying `UIImagePickerController` due to a bug in the closed-source tools built into iOS.
36+
3237
## Configuration in app.json/app.config.js
3338

3439
You can configure `expo-image-picker` using its built-in [config plugin](/config-plugins/introduction/) if you use config plugins in your project ([EAS Build](/build/introduction) or `npx expo run:[android|ios]`). The plugin allows you to configure various properties that cannot be set at runtime and require building a new app binary to take effect.
@@ -160,7 +165,7 @@ See [Amplify documentation](https://docs.amplify.aws/) guide to set up your proj
160165
title="Firebase storage example"
161166
description="An example of how to use Firebase storage can be found in with-firebase-storage-upload."
162167
Icon={GithubIcon}
163-
href="https://github.com/expo/examples/tree/master/with-aws-storage-upload"
168+
href="https://github.com/expo/examples/tree/master/with-firebase-storage-upload"
164169
/>
165170

166171
See [Using Firebase](/guides/using-firebase/) guide to set up your project correctly.
@@ -192,7 +197,3 @@ The following usage description keys are used by the APIs in this library.
192197
'NSCameraUsageDescription',
193198
]}
194199
/>
195-
196-
## Known issue
197-
198-
There is a known issue on iOS with the underlying `UIImagePickerController`. When an image (usually of a [higher resolution](http://www.openradar.me/49866214)) is picked from the camera roll, the result of the cropped image gives the wrong value for the cropped rectangle in some cases. Unfortunately, this issue is due to a bug in the closed source tools built into iOS.

0 commit comments

Comments
 (0)