-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "Authorization" header in import #255
Comments
Please keep in mind that the authentication scheme is custom-made, and not following some standard, e.g. bearer token or JWT. So there is possibly no point in using a standardized header name that 3rd party can send, if the header content cannot be produced correctly by that 3rd party software. Additionally, the name "Authentication" is more correct, as the header only proofs "who" the client is, not what the client is allowed to do (in contrast to modern API tokens and such). IIRC this was one of the reasons for choosing that particular header name. IMO you should clarify if you just find the name unsuitable or if you think the tracker should support a standard authentication/authorization mechanism like JWT. |
I believe you misunderstood. This issue is about using the "Authorization" header when requesting the schedule.xml for importing the Fahrplan into the tracker :) (I'm happy to provide a pull request for that later in the week) |
Ahh it's outgoing - okay, the code snippet was too short to see that. That is 100% useful of course. |
This is used (for example) by pretalx to access the schedule if it is set to not be available publicly. This fixes crs-tools#255
In
tracker/src/Application/Controller/Import.php
Lines 457 to 462 in a1757f5
The tracker should also have support for that header.
The text was updated successfully, but these errors were encountered: