Skip to content

Commit e69df56

Browse files
LukaFilipovic99jtomic-croz
authored andcommitted
#239 Remove sorting arrow icon when canSort prop is set to false in DataTable component
1 parent 9db6790 commit e69df56

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

libs/data-display/src/DataTable.tsx

+9-5
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,9 @@ function DataTable<T extends object>({
646646
className={tableHeaderClassName}
647647
title={column.title}
648648
onClick={() => {
649-
toggleSortBy(column.id, undefined, multiSort);
649+
if (column.canSort) {
650+
toggleSortBy(column.id, undefined, multiSort);
651+
}
650652
}}
651653
>
652654
<DataTableHeader alignHeader={alignHeader} {...column}>
@@ -815,10 +817,11 @@ function DataTableHeader({
815817
return (
816818
<div className={tableHeaderContainer}>
817819
{children}
818-
819-
<span className="flex justify-center items-center ml-1">
820-
{isSorted ? isSortedDesc ? sortDescIcon : sortAscIcon : canSort ? <div className="w-4 h-4">&nbsp;</div> : null}
821-
</span>
820+
{canSort && (
821+
<span className="flex justify-center items-center ml-1">
822+
{isSorted ? isSortedDesc ? sortDescIcon : sortAscIcon : <div className="w-3.5">&nbsp;</div>}
823+
</span>
824+
)}
822825
</div>
823826
);
824827
}
@@ -1081,6 +1084,7 @@ function DataTableColumn<T extends object>(_: DataTableColumnProps<T>) {
10811084

10821085
DataTableColumn.defaultProps = {
10831086
type: "DataTableColumn",
1087+
canSort: false,
10841088
};
10851089

10861090
function DataTableExpander<T>(_: DataTableExpanderProps<T>) {

0 commit comments

Comments
 (0)