Skip to content

Commit d3fb875

Browse files
coagulantcrccheck
authored andcommitted
Get rid of Django 2.0 DeprecationWarning (#78)
* Get rid of Django 2.0 DeprecationWarning Add 1.11 tox env * add missing compatibility imports and reorder for readability
1 parent 011ed07 commit d3fb875

File tree

7 files changed

+27
-5
lines changed

7 files changed

+27
-5
lines changed

django_object_actions/tests/test_admin.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,14 @@
33
"""
44
from __future__ import unicode_literals
55

6-
from django.core.urlresolvers import reverse
76
from django.http import HttpResponse
87
from mock import patch
98

9+
try:
10+
from django.urls import reverse
11+
except ImportError:
12+
from django.core.urlresolvers import reverse # < django 1.10
13+
1014
from .tests import LoggedInTestCase
1115
from example_project.polls.factories import CommentFactory, PollFactory
1216

django_object_actions/tests/tests.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
from django.core.urlresolvers import reverse
1+
try:
2+
from django.urls import reverse
3+
except ImportError:
4+
from django.core.urlresolvers import reverse # < django 1.10
25
from django.test import TestCase
36

47
from example_project.polls.factories import UserFactory

django_object_actions/utils.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,18 @@
55

66
from django.conf.urls import url
77
from django.contrib import messages
8-
from django.core.urlresolvers import reverse
98
from django.db.models.query import QuerySet
109
from django.http import Http404, HttpResponseRedirect
1110
from django.http.response import HttpResponseBase
1211
from django.views.generic import View
1312
from django.views.generic.detail import SingleObjectMixin
1413
from django.views.generic.list import MultipleObjectMixin
1514

15+
try:
16+
from django.urls import reverse
17+
except ImportError:
18+
from django.core.urlresolvers import reverse # < django 1.10
19+
1620

1721
class BaseDjangoObjectActions(object):
1822
"""

example_project/polls/admin.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,14 @@
22

33
from django.contrib import admin
44
from django.contrib.admin import AdminSite
5-
from django.core.urlresolvers import reverse
65
from django.db.models import F
76
from django.http import HttpResponseRedirect
87

8+
try:
9+
from django.urls import reverse
10+
except ImportError:
11+
from django.core.urlresolvers import reverse # < django 1.10
12+
913
from django_object_actions import (
1014
DjangoObjectActions, takes_instance_or_queryset)
1115

example_project/settings.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,11 @@ def project_dir(*paths):
6969
{
7070
'BACKEND': 'django.template.backends.django.DjangoTemplates',
7171
'APP_DIRS': True,
72+
'OPTIONS': {
73+
'context_processors': [
74+
'django.contrib.auth.context_processors.auth',
75+
],
76+
},
7277
},
7378
]
7479

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
dj-database-url==0.4.1
22
# Can upgrade once we lose DJANGO1.7
33
django-extensions==1.6.7
4-
factory-boy==2.7.0
4+
factory-boy==2.8.1
55
faker==0.7.7
66
coverage==4.2
77
mock==2.0.0

tox.ini

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ envlist =
77
django18-{py27,py34,py35},
88
django19-{py27,py34,py35},
99
django110-{py27,py35},
10+
django111-{py27,py35},
1011
# run one of the tests again but with coverage
1112
coveralls-django110-py35,
1213
skipsdist = True
@@ -23,6 +24,7 @@ deps =
2324
django18: Django<1.9
2425
django19: Django<1.10
2526
django110: Django<1.11
27+
django111: Django>=1.11rc1,<2.0
2628

2729
[testenv:coveralls-django110-py35]
2830
commands =

0 commit comments

Comments
 (0)