-
Notifications
You must be signed in to change notification settings - Fork 11
add user-mode networking option #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserve the tri-state semantics for UserModeNetworking
define.InitOptionsdocumentsnilas “use backend/system default”,falseas “force disable”, andtrueas “force enable”. Assigning&initOptionalFlags.UserModeNetworkingunconditionally forcesfalsewhenever the flag isn’t provided, overriding the provider’s default behaviour. This regresses existing flows (e.g. providers that rely onnilto auto-select networking).Only populate the pointer when the user explicitly sets the flag; otherwise leave it
nil.[suggested diff]
As per coding guidelines
📝 Committable suggestion
🤖 Prompt for AI Agents