Skip to content

Commit 25fe273

Browse files
committed
refactor: improve logging in gRPC services by removing service prefixes
- Updated log messages in NodeServiceServer and TaskServiceServer to remove the "[NodeServiceServer]" and "[TaskServiceServer]" prefixes for cleaner output. - This change enhances log readability and maintains consistency across logging practices in the application.
1 parent 3786ef3 commit 25fe273

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

core/grpc/server/node_service_server.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func (svr NodeServiceServer) Register(_ context.Context, req *grpc.NodeServiceRe
5151
if err != nil {
5252
return HandleError(err)
5353
}
54-
svr.Infof("[NodeServiceServer] updated worker[%s] in db. id: %s", req.NodeKey, node.Id.Hex())
54+
svr.Infof("updated worker[%s] in db. id: %s", req.NodeKey, node.Id.Hex())
5555
} else if errors2.Is(err, mongo.ErrNoDocuments) {
5656
// register new
5757
node = &models.Node{
@@ -69,13 +69,13 @@ func (svr NodeServiceServer) Register(_ context.Context, req *grpc.NodeServiceRe
6969
if err != nil {
7070
return HandleError(err)
7171
}
72-
svr.Infof("[NodeServiceServer] added worker[%s] in db. id: %s", req.NodeKey, node.Id.Hex())
72+
svr.Infof("added worker[%s] in db. id: %s", req.NodeKey, node.Id.Hex())
7373
} else {
7474
// error
7575
return HandleError(err)
7676
}
7777

78-
svr.Infof("[NodeServiceServer] master registered worker[%s]", req.NodeKey)
78+
svr.Infof("master registered worker[%s]", req.NodeKey)
7979

8080
return HandleSuccessWithData(node)
8181
}
@@ -113,12 +113,12 @@ func (svr NodeServiceServer) SendHeartbeat(_ context.Context, req *grpc.NodeServ
113113
}
114114

115115
func (svr NodeServiceServer) Subscribe(request *grpc.NodeServiceSubscribeRequest, stream grpc.NodeService_SubscribeServer) (err error) {
116-
svr.Infof("[NodeServiceServer] master received subscribe request from node[%s]", request.NodeKey)
116+
svr.Infof("master received subscribe request from node[%s]", request.NodeKey)
117117

118118
// find in db
119119
node, err := service.NewModelService[models.Node]().GetOne(bson.M{"key": request.NodeKey}, nil)
120120
if err != nil {
121-
svr.Errorf("[NodeServiceServer] error getting node: %v", err)
121+
svr.Errorf("error getting node: %v", err)
122122
return err
123123
}
124124

@@ -136,7 +136,7 @@ func (svr NodeServiceServer) Subscribe(request *grpc.NodeServiceSubscribeRequest
136136
nodeServiceMutex.Lock()
137137
delete(svr.subs, node.Id)
138138
nodeServiceMutex.Unlock()
139-
svr.Infof("[NodeServiceServer] master unsubscribed from node[%s]", request.NodeKey)
139+
svr.Infof("master unsubscribed from node[%s]", request.NodeKey)
140140

141141
return nil
142142
}

core/grpc/server/task_service_server.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func (svr TaskServiceServer) Subscribe(req *grpc.TaskServiceSubscribeRequest, st
6262
taskServiceMutex.Lock()
6363
delete(svr.subs, taskId)
6464
taskServiceMutex.Unlock()
65-
svr.Infof("[TaskServiceServer] task stream closed: %s", taskId.Hex())
65+
svr.Infof("task stream closed: %s", taskId.Hex())
6666

6767
return nil
6868
}

0 commit comments

Comments
 (0)