Chore: Implement suggestions by CodeRabbit

- Remove redundant test function `testPrepareWithBindParam`
- Remove deprecated test function about `PDO::FETCH_CLASS`
- Complete function signature type hinting
- Improve MapType::convertToPHPValue about accounting for `null` values

Author: amotl

src/Crate/DBAL/Types/ArrayType.php

@@ -95,7 +95,7 @@ public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $pla
      * @return string
      * @throws \Doctrine\DBAL\Exception
      */
-    public function getArrayTypeDeclarationSQL(AbstractPlatform $platform, array $field, array $options)
+    public function getArrayTypeDeclarationSQL(AbstractPlatform $platform, array $field, array $options): string
     {
         $type = array_key_exists('type', $options) ? $options['type'] : Types::STRING;
         return 'ARRAY ( ' . Type::getType($type)->getSQLDeclaration($field, $platform) . ' )';

src/Crate/DBAL/Types/MapType.php

@@ -64,7 +64,7 @@ public function getBindingType()
 
     public function convertToDatabaseValue($value, AbstractPlatform $platform): mixed
     {
-        if (!is_array($value) || (count($value) > 0 && !(array_keys($value) !== range(0, count($value) - 1)))) {
+        if (!is_array($value) || (count($value) > 0 && array_keys($value) === range(0, count($value) - 1))) {
             return null;
         }
 
@@ -73,7 +73,10 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform): mixe
 
     public function convertToPHPValue($value, AbstractPlatform $platform): mixed
     {
-        return $value == null ?: (array) $value;
+        if ($value === null) {
+            return null;
+        }
+        return (array) $value;
     }
 
     /**
@@ -100,7 +103,7 @@ public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $pla
      * @return string
      * @throws \Doctrine\DBAL\Exception
      */
-    public function getMapTypeDeclarationSQL(AbstractPlatform $platform, array $field, array $options)
+    public function getMapTypeDeclarationSQL(AbstractPlatform $platform, array $field, array $options): string
     {
         $type = array_key_exists('type', $options) ? $options['type'] : MapType::DYNAMIC;
 

test/Crate/Test/DBAL/Functional/DataAccessTest.php

@@ -100,24 +100,6 @@ public function testPrepareWithBindValue()
         $this->assertEquals(array('test_int' => 1, 'test_string' => 'foo'), $row);
     }
 
-    public function testPrepareWithBindParam()
-    {
-        $paramInt = 1;
-        $paramStr = 'foo';
-
-        $sql = "SELECT test_int, test_string FROM fetch_table WHERE test_int = ? AND test_string = ?";
-        $stmt = $this->_conn->prepare($sql);
-        $this->assertInstanceOf('Doctrine\DBAL\Statement', $stmt);
-
-        $stmt->bindValue(1, $paramInt, PDO::PARAM_INT);
-        $stmt->bindValue(2, $paramStr, PDO::PARAM_STR);
-        $result = $stmt->executeQuery();
-
-        $row = $result->fetchAssociative();
-        $row = array_change_key_case($row, \CASE_LOWER);
-        $this->assertEquals(array('test_int' => 1, 'test_string' => 'foo'), $row);
-    }
-
     public function testPrepareWithFetchAll()
     {
         $paramInt = 1;
@@ -436,32 +418,6 @@ public function testSetDefaultFetchMode()
         $this->assertEquals(0, count( array_filter($row, function($v) { return ! is_numeric($v); })), "should be no non-numerical elements in the result.");
     }
 
-    /**
-     * @group DBAL-196
-     */
-    public function testFetchAllSupportFetchClass()
-    {
-        $this->markTestSkipped("PDO::FETCH_CLASS is not supported by the CrateDB PDO driver");
-
-        $this->setupFixture();
-
-        $sql    = "SELECT test_int, test_string, test_datetime FROM fetch_table";
-        $stmt   = $this->_conn->prepare($sql);
-        $result = $stmt->executeQuery();
-
-        $results = $result->fetch(
-            PDO::FETCH_CLASS,
-            __NAMESPACE__.'\\MyFetchClass'
-        );
-
-        $this->assertEquals(1, count($results));
-        $this->assertInstanceOf(__NAMESPACE__.'\\MyFetchClass', $results[0]);
-
-        $this->assertEquals(1, $results[0]->test_int);
-        $this->assertEquals('foo', $results[0]->test_string);
-        $this->assertStringStartsWith('2010-01-01T10:10:10', $results[0]->test_datetime);
-    }
-
     /**
      * @group DBAL-241
      */