DBAL3: Improve exception handling

Author: JulianMar

src/Crate/DBAL/Platforms/CratePlatform.php

@@ -28,7 +28,6 @@
 use Doctrine\DBAL\Event\SchemaCreateTableColumnEventArgs;
 use Doctrine\DBAL\Event\SchemaCreateTableEventArgs;
 use Doctrine\DBAL\Events;
-use Doctrine\DBAL\Exception as DBALException;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Schema\ForeignKeyConstraint;
 use Doctrine\DBAL\Schema\Identifier;
@@ -76,7 +75,7 @@ public function getSubstringExpression($value, $from = 0, $length = null): strin
      */
     public function getNowExpression()
     {
-        throw DBALException::notSupported(__METHOD__);
+        throw Exception::notSupported(__METHOD__);
     }
 
     /**
@@ -92,7 +91,7 @@ public function getRegexpExpression(): string
      */
     public function getDateDiffExpression($date1, $date2): string
     {
-        throw DBALException::notSupported(__METHOD__);
+        throw Exception::notSupported(__METHOD__);
     }
 
     /**
@@ -175,7 +174,7 @@ public function prefersSequences()
      */
     public function getListDatabasesSQL(): string
     {
-        throw DBALException::notSupported(__METHOD__);
+        throw Exception::notSupported(__METHOD__);
     }
 
     /**
@@ -270,20 +269,20 @@ public function getAlterTableSQL(TableDiff $diff): array
         }
 
         if (count($diff->removedColumns) > 0) {
-            throw DBALException::notSupported("Alter Table: drop columns");
+            throw Exception::notSupported("Alter Table: drop columns");
         }
         if (count($diff->changedColumns) > 0) {
-            throw DBALException::notSupported("Alter Table: change column options");
+            throw Exception::notSupported("Alter Table: change column options");
         }
         if (count($diff->renamedColumns) > 0) {
-            throw DBALException::notSupported("Alter Table: rename columns");
+            throw Exception::notSupported("Alter Table: rename columns");
         }
 
         $tableSql = array();
 
         if (!$this->onSchemaAlterTable($diff, $tableSql)) {
             if ($diff->newName !== false) {
-                throw DBALException::notSupported("Alter Table: rename table");
+                throw Exception::notSupported("Alter Table: rename table");
             }
 
             $sql = array_merge($sql, $this->getPreAlterTableIndexForeignKeySQL($diff), $commentsSQL);
@@ -514,15 +513,15 @@ public function getTimeFormatString(): string
      */
     public function getTruncateTableSQL($tableName, $cascade = false): string
     {
-        throw DBALException::notSupported(__METHOD__);
+        throw Exception::notSupported(__METHOD__);
     }
 
     /**
      * {@inheritDoc}
      */
     public function getReadLockSQL()
     {
-        throw DBALException::notSupported(__METHOD__);
+        throw Exception::notSupported(__METHOD__);
     }
 
     /**
@@ -580,7 +579,7 @@ protected function getReservedKeywordsClass()
      */
     public function getBlobTypeDeclarationSQL(array $field): string
     {
-        throw DBALException::notSupported(__METHOD__);
+        throw Exception::notSupported(__METHOD__);
     }
 
     /**
@@ -620,7 +619,7 @@ public function getCreateTableSQL(Table $table, $createFlags = self::CREATE_INDE
                     }, $index->getColumns());
                     $options['primary_index'] = $index;
                 } elseif ($index->isUnique()) {
-                    throw DBALException::notSupported(
+                    throw Exception::notSupported(
                         "Unique constraints are not supported. Use `primary key` instead"
                     );
                 } else {
@@ -693,7 +692,7 @@ protected function _getCreateTableSQL($name, array $columns, array $options = ar
         }
 
         if (isset($options['foreignKeys'])) {
-            throw DBALException::notSupported("Create Table: foreign keys");
+            throw Exception::notSupported("Create Table: foreign keys");
         }
 
         $query = 'CREATE TABLE ' . $name . ' (' . $columnListSql . ')';
@@ -783,12 +782,12 @@ private function buildPartitionOptions(array $options)
      * @param array List of primary key column names
      *
      * @return array The column data as associative array.
-     * @throws DBALException
+     * @throws Exception
      */
     public static function prepareColumnData(AbstractPlatform $platform, $column, $primaries = array())
     {
         if ($column->hasCustomSchemaOption("unique") ? $column->getCustomSchemaOption("unique") : false) {
-            throw DBALException::notSupported("Unique constraints are not supported. Use `primary key` instead");
+            throw Exception::notSupported("Unique constraints are not supported. Use `primary key` instead");
         }
 
         $columnData = array();
@@ -826,31 +825,31 @@ public static function prepareColumnData(AbstractPlatform $platform, $column, $p
      */
     public function getCreateDatabaseSQL($database): string
     {
-        throw DBALException::notSupported(__METHOD__);
+        throw Exception::notSupported(__METHOD__);
     }
 
     /**
      * {@inheritDoc}
      */
     public function getDropDatabaseSQL($database): string
     {
-        throw DBALException::notSupported(__METHOD__);
+        throw Exception::notSupported(__METHOD__);
     }
 
     /**
      * {@inheritDoc}
      */
     public function getCreateForeignKeySQL(ForeignKeyConstraint $foreignKey, $table): string
     {
-        throw DBALException::notSupported(__METHOD__);
+        throw Exception::notSupported(__METHOD__);
     }
 
     /**
      * {@inheritDoc}
      */
     public function getGuidTypeDeclarationSQL(array $field): string
     {
-        throw DBALException::notSupported(__METHOD__);
+        throw Exception::notSupported(__METHOD__);
     }
 
     /**

src/Crate/DBAL/Platforms/Exception.php

@@ -0,0 +1,12 @@
+<?php
+namespace Crate\DBAL\Platforms;
+use Doctrine\DBAL\Exception as DoctrineException;
+class Exception extends \Exception implements DoctrineException
+{
+    public static function notSupported(string $method): self
+    {
+        return new self(sprintf("Operation '%s' is not supported by platform.", $method));
+    }
+}
+
+?>