-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving cleanup to dramatically reduce image size #94
Comments
@roelvanhintum Please see #93 |
@timkelty Thanks! Regardless of that, it would still be a huge improvement. Maybe this is also the case in the new images? |
@roelvanhintum agreed! We're happy to accept a PR, or if we get the time before we officially read-only this repo, it seems worthwhile. I'm going to leave this open for now. Pinging @jasonmccallister to make any cleanup is happening in the appropriate layers in the new images. |
Description
Moving cleanup to the same RUN as install and build reduces image size. Right now the cleanup is a separate RUN command in the docker files. At the end of a RUN command a new layer is created. Doing cleanup in a later layer does nothing for the resulting docker image.
Steps to reproduce
Additional info
craftcms/cms
version: -The text was updated successfully, but these errors were encountered: