Payments after order submited no longer works

[mufi-siebird]

So Craft Commerce provides a feature where you can submit cart without payment and later ask for payment on completed order. that no longer works due to this JS change 5.0.4.2...5.0.4.3

As that added this JS code that has 2 issues:

if(json.redirect && json.cart.isCompleted === true) {
      window.location.href = json.redirect;
      return;
}

1. json.cart is not a variable on order payment form. its json.order
2. As isCompleted variable is true in that case, it goes to return and thus payment form does not appears.

Suggested solution:

if(json.redirect && typeof(json.cart) !== "undefined" && json.cart.isCompleted === true) {
      window.location.href = json.redirect;
      return;
}

[linear]

PT-2203 Payments after order submited no longer works

[KasimMahroof]

The company I work for has also ran into this issue on the 4.x branch.

Unfortunately, this has broken partial payments for our users, forcing us to downgrade.

It would be greatly appreciated if this could be addressed in the next release.