no native VAOs

Author: igagis

src/ruis/render/opengl/shader_base.cpp

@@ -183,25 +183,11 @@ void shader_base::render(const r4::matrix4<float>& m, const ruis::render::vertex
 	// NOLINTNEXTLINE(cppcoreguidelines-pro-type-static-cast-downcast)
 	const auto& ogl_va = static_cast<const vertex_array&>(va);
 
-	if (GLEW_ARB_vertex_array_object) {
-		glBindVertexArray(ogl_va.vao);
-		assert_opengl_no_error();
-	} else {
-		ogl_va.bind_buffers();
-	}
+	ogl_va.bind_buffers();
 
 	//	TRACE(<< "ivbo.elementsCount = " << ivbo.elementsCount << "
 	// ivbo.elementType = " << ivbo.elementType << std::endl)
 
 	glDrawElements(mode_to_gl_mode(va.rendering_mode), ivbo.elements_count, ivbo.element_type, nullptr);
 	assert_opengl_no_error();
-
-	if (GLEW_ARB_vertex_array_object) {
-		// For some reason on linux when leaving bound vertex array after done with
-		// rendering a frame, the vertex array can become corrupted in some
-		// scenarios, like changing viewport size and possibly some other scenarios.
-		// Because of that, unbind the vertex array after glDrawElements() call.
-		glBindVertexArray(0);
-		assert_opengl_no_error();
-	}
 }

src/ruis/render/opengl/vertex_array.cpp

@@ -38,44 +38,8 @@ vertex_array::vertex_array(
 		std::move(buffers),
 		std::move(indices),
 		rendering_mode
-	),
-	vao([]() {
-		if (GLEW_ARB_vertex_array_object) {
-			// NOLINTNEXTLINE(cppcoreguidelines-init-variables)
-			GLuint ret;
-			glGenVertexArrays(1, &ret);
-			assert_opengl_no_error();
-			return ret;
-		} else {
-			return GLuint(0);
-		}
-	}())
-{
-	if (GLEW_ARB_vertex_array_object) {
-		glBindVertexArray(this->vao);
-		assert_opengl_no_error();
-
-		this->bind_buffers();
-
-		glBindVertexArray(0);
-		assert_opengl_no_error();
-
-		glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, 0);
-		assert_opengl_no_error();
-		glBindBuffer(GL_ARRAY_BUFFER, 0);
-		assert_opengl_no_error();
-	}
-}
-
-vertex_array::~vertex_array()
-{
-	if (GLEW_ARB_vertex_array_object) {
-		glBindVertexArray(0);
-		assert_opengl_no_error();
-		glDeleteVertexArrays(1, &this->vao);
-		assert_opengl_no_error();
-	}
-}
+	)
+{}
 
 void vertex_array::bind_buffers() const
 {

src/ruis/render/opengl/vertex_array.hpp

@@ -29,7 +29,7 @@ namespace ruis::render::opengl {
 class vertex_array : public ruis::render::vertex_array
 {
 public:
-	const GLuint vao;
+	// NOTE: The native OpenGL Vertex Array Object is not used because it cannot be shared between OpenGL contexts.
 
 	vertex_array(
 		utki::shared_ref<ruis::render::renderer> renderer, //
@@ -44,7 +44,7 @@ class vertex_array : public ruis::render::vertex_array
 	vertex_array(vertex_array&&) = delete;
 	vertex_array& operator=(vertex_array&&) = delete;
 
-	~vertex_array() override;
+	~vertex_array() override = default;
 
 	void bind_buffers() const;