Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better log output #48

Closed
2bndy5 opened this issue Sep 28, 2024 · 1 comment · Fixed by #52
Closed

better log output #48

2bndy5 opened this issue Sep 28, 2024 · 1 comment · Fixed by #52
Labels
enhancement New feature or request

Comments

@2bndy5
Copy link
Collaborator

2bndy5 commented Sep 28, 2024

I want colored logs 🎨

This can be condition by using an env variable (CPP_LINTER_COLOR maybe?). It would require some alteration in the logger dependency though.

By default, we can have the color disabled in CI (like many other tools), but we can have color enabled during local (not CI) execution.

Less logs from dependencies

Currently the debug output includes logs from reqwest library:

DEBUG: starting new connection: https://api.github.com/
DEBUG: starting new connection: https://api.github.com/

This is rather superfluous to the end-user and shouldn't be shown. It just adds clutter to the log output.

@2bndy5 2bndy5 added the enhancement New feature or request label Sep 28, 2024
@2bndy5 2bndy5 linked a pull request Oct 2, 2024 that will close this issue
@2bndy5
Copy link
Collaborator Author

2bndy5 commented Oct 2, 2024

Less logs from dependencies

This is actually related to not using asynchronous channels from tokio dependency. (related to #10 )

I'm still looking into that..

@2bndy5 2bndy5 closed this as completed in #52 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant