Skip to content

switch to quick_xml #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2bndy5 opened this issue Jan 20, 2025 · 1 comment · Fixed by #101
Closed

switch to quick_xml #100

2bndy5 opened this issue Jan 20, 2025 · 1 comment · Fixed by #101
Labels
enhancement New feature or request

Comments

@2bndy5
Copy link
Collaborator

2bndy5 commented Jan 20, 2025

Currently, We're using a library to parse XML (from clang-format output) named serde-xml-rs. I found we can easily migrate to quick_xml instead.

Why?

This idea aims to resolve

  1. quick_xml is a faster XML parser:
    // serde-xml-rs vs serialize feature
    test bench_serde_quick_xml      ... bench:   1,181,198 ns/iter (+/- 138,290)
    test bench_serde_xml_rs         ... bench:  15,039,564 ns/iter (+/- 783,485)
    
  2. quick_xml is actively developed, whereas serde_xml_rs has not seen attention for over 2 years at this point.
@2bndy5 2bndy5 added the enhancement New feature or request label Jan 20, 2025
@2bndy5
Copy link
Collaborator Author

2bndy5 commented Jan 20, 2025

Oh, this is ticket #100!

@2bndy5 2bndy5 linked a pull request Jan 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant