feat(backend): fix

Author: kidkidkid

backend/modules/observability/infra/config/trace.go

@@ -10,6 +10,7 @@ import (
 	"github.com/coze-dev/coze-loop/backend/modules/observability/domain/component/config"
 	"github.com/coze-dev/coze-loop/backend/modules/observability/domain/trace/entity/loop_span"
 	"github.com/coze-dev/coze-loop/backend/pkg/conf"
+	"github.com/coze-dev/coze-loop/backend/pkg/json"
 	"github.com/coze-dev/coze-loop/backend/pkg/logs"
 )
 
@@ -53,8 +54,17 @@ func (t *TraceConfigCenter) GetPlatformTenants(ctx context.Context) (*config.Pla
 
 func (t *TraceConfigCenter) GetPlatformSpansTrans(ctx context.Context, platformType loop_span.PlatformType) (loop_span.SpanTransCfgList, error) {
 	cfg := new(config.SpanTransHandlerConfig)
-	if err := t.UnmarshalKey(ctx, platformSpanHandlerCfgKey, cfg); err != nil {
-		return nil, err
+	val := t.Get(ctx, platformSpanHandlerCfgKey)
+	if val == nil {
+		return nil, fmt.Errorf("config not found")
+	}
+	strVal, ok := val.(string)
+	if !ok {
+		return nil, fmt.Errorf("config not string")
+	}
+	// unmarshal to avoid data race
+	if err := json.Unmarshal([]byte(strVal), cfg); err != nil {
+		return nil, fmt.Errorf("fail to unmarshal config: %v", err)
 	}
 	ret := cfg.PlatformCfg[string(platformType)]
 	for _, inheritance := range cfg.PlatformInheritance[string(platformType)] {

backend/modules/observability/infra/config/trace_test.go

@@ -159,33 +159,22 @@ func TestTraceConfigCenter_GetPlatformSpansTrans(t *testing.T) {
 			name: "get platform spans trans successfully",
 			fieldsGetter: func(ctrl *gomock.Controller) fields {
 				mockLoader := confmocks.NewMockIConfigLoader(ctrl)
-				mockLoader.EXPECT().UnmarshalKey(gomock.Any(), platformSpanHandlerCfgKey, gomock.Any()).
-					DoAndReturn(func(ctx context.Context, key string, v interface{}, opts ...interface{}) error {
-						cfg := v.(*config.SpanTransHandlerConfig)
-						cfg.PlatformCfg = map[string]loop_span.SpanTransCfgList{
-							"test_platform": {
-								{},
-							},
-						}
-						return nil
-					})
+				mockLoader.EXPECT().Get(gomock.Any(), platformSpanHandlerCfgKey).Return(`{"platform_cfg":{"test_platform":[]}}`)
 				return fields{configLoader: mockLoader}
 			},
 			args: args{
 				ctx:          context.Background(),
 				platformType: "test_platform",
 			},
-			want: loop_span.SpanTransCfgList{
-				{},
-			},
+			want:    loop_span.SpanTransCfgList{},
 			wantErr: false,
 		},
 		{
 			name: "unmarshal key failed",
 			fieldsGetter: func(ctrl *gomock.Controller) fields {
 				mockLoader := confmocks.NewMockIConfigLoader(ctrl)
-				mockLoader.EXPECT().UnmarshalKey(gomock.Any(), platformSpanHandlerCfgKey, gomock.Any()).
-					Return(fmt.Errorf("unmarshal error"))
+				mockLoader.EXPECT().Get(gomock.Any(), platformSpanHandlerCfgKey).
+					Return(nil)
 				return fields{configLoader: mockLoader}
 			},
 			args: args{