fix: correctly parse permission models from json file (#306)

https://coveord.atlassian.net/browse/CDX-1447

Author: y-lakhdar

src/__stub__/jsondocuments/complexPermissionModel.json

@@ -0,0 +1,58 @@
+[
+  {
+    "author": "Sample Group",
+    "documenttype": "Video",
+    "duration": 180.72,
+    "filename": "myvideo.avi",
+    "language": ["English"],
+    "permanentid": "my94293video03938permanent93892id",
+    "sourcetype": "Push",
+    "title": "My Video",
+    "compressionType": "LZMA",
+    "documentId": "http://www.example.com/myvideo.avi",
+    "fileExtension": ".avi",
+    "permissions": [
+      {
+        "name": "MyPermissionLevel1",
+        "permissionSets": [
+          {
+            "allowAnonymous": false,
+            "allowedPermissions": [
+              {
+                "identity": "SampleGroup",
+                "identityType": "GrOup"
+              }
+            ],
+            "deniedPermissions": [
+              {
+                "identity": "[email protected]",
+                "identityType": "User",
+                "securityProvider": "My Security Identity Provider"
+              }
+            ]
+          }
+        ]
+      },
+      {
+        "name": "MyPermissionLevel2",
+        "permissionSets": [
+          {
+            "allowAnonymous": false,
+            "allowedPermissions": [
+              {
+                "identity": "SampleGroup2",
+                "identityType": "Group"
+              }
+            ],
+            "deniedPermissions": [
+              {
+                "identity": "[email protected]",
+                "identityType": "User"
+              }
+            ]
+          }
+        ]
+      }
+    ]
+  }
+]

src/validation/parseFile.spec.ts

@@ -96,6 +96,17 @@ describe('parseFile', () => {
     await expect(parse(file)).rejects.toThrow(error);
   });
 
+  it('should support complex permission models', async () => {
+    const file = join(
+      pathToStub,
+      'jsondocuments',
+      'complexPermissionModel.json'
+    );
+    await expect(
+      parseAndGetDocumentBuilderFromJSONDocument(file)
+    ).resolves.not.toThrow();
+  });
+
   it('should not throw if allowedPermissions or deniedPermissions are omitted', async () => {
     const file = join(pathToStub, 'jsondocuments', 'limitedPermissionSet.json');
     await expect(

src/validation/parsePermissions.ts

@@ -42,12 +42,8 @@ class PermissionParser {
             new CaseInsensitiveDocument<PrimitivesValues>(permission);
 
           new KnownKeys('permissionsets', caseInsensitivePermission)
-            .whenExists<PermissionLevel>((permissionLevel) =>
-              this.processPermissionLevel(permissionLevel)
-            )
-            .whenDoesNotExist<PermissionSet>((permissionSet) =>
-              this.processPermissionSet(permissionSet)
-            );
+            .whenExists(() => this.processPermissionLevel(permission))
+            .whenDoesNotExist(() => this.processPermissionSet(permission));
         }
       );