Skip to content

Commit d0e7418

Browse files
committed
refactor: cleaner code
1 parent 591e8ae commit d0e7418

File tree

2 files changed

+17
-11
lines changed

2 files changed

+17
-11
lines changed

microservices/tx/tx.routes.ts

+1-9
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,11 @@ const handleDecode = async (
2626
"x-covalent-api-key"
2727
];
2828
const { network, tx_hash } = req.body as DecodeTXRequest;
29-
const tx = await fetchTxDataFromHash(
29+
const { log_events, metadata } = await fetchTxDataFromHash(
3030
network as Chain,
3131
tx_hash,
3232
covalentApiKey
3333
);
34-
const {
35-
dex_details,
36-
nft_sale_details,
37-
lending_details,
38-
safe_details,
39-
log_events,
40-
...metadata
41-
} = tx;
4234
const events = await fetchEventsFromLogs(
4335
network as Chain,
4436
log_events,

microservices/tx/tx.service.ts

+16-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ export const fetchTxDataFromHash = async (
1010
network: Chain,
1111
tx_hash: string,
1212
covalentApiKey: string
13-
) => {
13+
): Promise<{
14+
log_events: LogEvent[];
15+
metadata: TransactionMetadata;
16+
}> => {
1417
const covalentClient = new CovalentClient(covalentApiKey);
1518
const { data, error_code, error_message } =
1619
await covalentClient.TransactionService.getTransaction(
@@ -27,7 +30,18 @@ export const fetchTxDataFromHash = async (
2730
);
2831
const tx = data?.items?.[0];
2932
if (tx) {
30-
return tx;
33+
const {
34+
log_events,
35+
dex_details,
36+
nft_sale_details,
37+
lending_details,
38+
safe_details,
39+
...metadata
40+
} = tx;
41+
return {
42+
log_events: log_events,
43+
metadata: metadata,
44+
};
3145
} else {
3246
throw {
3347
errorCode: error_code,

0 commit comments

Comments
 (0)