diff --git a/libraries/utilities/download-release-packages.py b/libraries/utilities/download-release-packages.py index e2d9f25cb4..89d3584003 100644 --- a/libraries/utilities/download-release-packages.py +++ b/libraries/utilities/download-release-packages.py @@ -98,7 +98,26 @@ def pull_package_and_dump_contents(package_defs): elif file_name.endswith(".tar.gz"): with tarfile.open(file_name) as tar_f: - tar_f.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar_f) else: raise ValueError("Unable to extract package: {}".format(file_name))