CXXCBC-745: Lazy connections #863
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsej
force-pushed
the
lazy-connections
branch
from
18eaf47 to
0ffac94
Compare
Matt-Woz
approved these changes
Nov 6, 2025
Do not rush to open KV connections after the first configuration has been received. Instead wait for the first operation that would be mapped to the socket.
avsej
force-pushed
the
lazy-connections
branch
from
0ffac94 to
4e0059f
Compare
thejcfactor
reviewed
Nov 10, 2025
| session.has_value() ? session->bootstrap_address() : "", | ||
| session.has_value() && session->has_config(), | ||
| config_rev()); | ||
| if (!session) { |
Contributor
There was a problem hiding this comment.
If lazy connections are not enabled, we want to defer the command still, right?
Member
Author
There was a problem hiding this comment.
@thejcfactor right, we always defer the command. This change just ensures that the connection exist or pending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.